Issue 10827463: Fixes cloud-printer being treated as local-printer problem.

Issue 10827463: Fixes cloud-printer being treated as local-printer problem. (Closed)

Created:
8 years, 4 months ago by Robert Toscano

Modified:
8 years, 4 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fixes cloud-printer being treated as local-printer problem. BUG=144048 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153263

Patch Set 2 : Integrated Vitaly's changes. #

Total comments: 2

Patch Set 3 : Fixes JSDoc comment. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -33 lines)			Patch
M	chrome/browser/resources/print_preview/cloud_print_interface.js	View	1	8 chunks	+33 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/print_preview/data/destination_store.js	View	1 2	8 chunks	+73 lines, -19 lines	0 comments	Download
M	chrome/browser/resources/print_preview/native_layer.js	View	1	10 chunks	+52 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Robert Toscano

I incorporated the changes from Vitaly's change. PTAL. Btw, the CL is being uploaded right ...

8 years, 4 months ago (2012-08-23 22:49:28 UTC) #4

Robert Toscano

Ok now its all there, sorry I had some problems with my local client.

8 years, 4 months ago (2012-08-24 01:21:10 UTC) #5

Albert Bodenhamer

LGTM NIT: Please fix the confusing TODO comment below. http://codereview.chromium.org/10827463/diff/5002/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): http://codereview.chromium.org/10827463/diff/5002/chrome/browser/resources/print_preview/data/destination_store.js#newcode463 chrome/browser/resources/print_preview/data/destination_store.js:463: ...

8 years, 4 months ago (2012-08-24 16:07:26 UTC) #6

Robert Toscano

http://codereview.chromium.org/10827463/diff/5002/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): http://codereview.chromium.org/10827463/diff/5002/chrome/browser/resources/print_preview/data/destination_store.js#newcode463 chrome/browser/resources/print_preview/data/destination_store.js:463: * fails. TODO(rltoscano) On 2012/08/24 16:07:26, Albert Bodenhamer wrote: ...

8 years, 4 months ago (2012-08-24 17:27:49 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@google.com/10827463/3003

8 years, 4 months ago (2012-08-24 17:28:13 UTC) #8

Change committed as 153263

Expand Messages | Collapse Messages