Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

Issue 10827390: Implement chrome.socket.bind/listen/accept for TCP server socket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unrelated changes. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
diff --git a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
index 16ae87967d50ba59a2c58493410d0759be5257b4..f8819faee4fc2f9b7402dd47ef399059e790da36 100644
--- a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
+++ b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
@@ -12,6 +12,7 @@
#include "net/base/net_errors.h"
#include "net/base/rand_callback.h"
#include "net/socket/tcp_client_socket.h"
+#include "net/socket/tcp_server_socket.h"
#include "testing/gmock/include/gmock/gmock.h"
using testing::_;
@@ -41,6 +42,19 @@ class MockTCPSocket : public net::TCPClientSocket {
DISALLOW_COPY_AND_ASSIGN(MockTCPSocket);
};
+class MockTCPServerSocket : public net::TCPServerSocket {
+ public:
+ explicit MockTCPServerSocket()
+ : net::TCPServerSocket(NULL, net::NetLog::Source()) {
+ }
+ MOCK_METHOD2(Listen, int(const net::IPEndPoint& address, int backlog));
+ MOCK_METHOD2(Accept, int(scoped_ptr<net::StreamSocket>* socket,
+ const net::CompletionCallback& callback));
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockTCPServerSocket);
+};
+
class MockApiResourceEventNotifier : public ApiResourceEventNotifier {
public:
MockApiResourceEventNotifier() : ApiResourceEventNotifier(NULL, NULL,
@@ -61,6 +75,7 @@ class CompleteHandler {
MOCK_METHOD1(OnComplete, void(int result_code));
MOCK_METHOD2(OnReadComplete, void(int result_code,
scoped_refptr<net::IOBuffer> io_buffer));
+ MOCK_METHOD2(OnAccept, void(int, net::TCPClientSocket*));
private:
DISALLOW_COPY_AND_ASSIGN(CompleteHandler);
};
@@ -219,4 +234,25 @@ TEST(SocketTest, TestTCPSocketSetKeepAlive) {
EXPECT_EQ(0, delay);
}
+TEST(SocketTest, TestTCPServerSocketListenAccept) {
+ MockTCPServerSocket* tcp_server_socket = new MockTCPServerSocket();
+ CompleteHandler handler;
+
+ scoped_ptr<TCPSocket> socket(TCPSocket::CreateServerSocketForTesting(
+ tcp_server_socket));
+
+ EXPECT_CALL(*tcp_server_socket, Listen(_, _)).Times(1);
+ EXPECT_CALL(*tcp_server_socket, Accept(_, _)).Times(1);
+ EXPECT_CALL(handler, OnAccept(_, _));
+
+ // Should fail if we try to listen without calling bind() first.
+ std::string err_msg;
+ EXPECT_EQ(net::ERR_FAILED, socket->Listen(10, err_msg));
+
+ EXPECT_TRUE(socket->Bind("127.0.0.1", 9999));
+ EXPECT_EQ(0, socket->Listen(10, err_msg));
+ socket->Accept(base::Bind(&CompleteHandler::OnAccept,
+ base::Unretained(&handler)));
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698