Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5235)

Unified Diff: chrome/browser/extensions/api/socket/socket.cc

Issue 10827390: Implement chrome.socket.bind/listen/accept for TCP server socket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, add permissions test, fix bug with accept() Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/socket.cc
diff --git a/chrome/browser/extensions/api/socket/socket.cc b/chrome/browser/extensions/api/socket/socket.cc
index 3d297217896471e1bcdcdc04a870891dc1532d70..78eaf64546fc5e7025ef165261ff1ee5e2401bee 100644
--- a/chrome/browser/extensions/api/socket/socket.cc
+++ b/chrome/browser/extensions/api/socket/socket.cc
@@ -87,6 +87,15 @@ bool Socket::SetNoDelay(bool no_delay) {
return false;
}
+int Socket::Listen(const std::string& address, int port, int backlog,
+ std::string* error_msg) {
+ return net::ERR_FAILED;
miket_OOO 2012/09/26 21:02:44 Good stuff, thanks. This looks much better. Next
justinlin 2012/09/26 23:03:57 Done. Added the error message. I think write() was
+}
+
+void Socket::Accept(const AcceptCompletionCallback& callback) {
+ callback.Run(net::ERR_FAILED, NULL);
+}
+
// static
bool Socket::StringAndPortToIPEndPoint(const std::string& ip_address_str,
int port,

Powered by Google App Engine
This is Rietveld 408576698