Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2432)

Unified Diff: chrome/browser/extensions/api/socket/socket.cc

Issue 10827390: Implement chrome.socket.bind/listen/accept for TCP server socket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments, set default for listen backlog to 5 Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/socket.cc
diff --git a/chrome/browser/extensions/api/socket/socket.cc b/chrome/browser/extensions/api/socket/socket.cc
index 3d297217896471e1bcdcdc04a870891dc1532d70..2af0c452b4a346d9f73ea4d4a13d0e192c8b107b 100644
--- a/chrome/browser/extensions/api/socket/socket.cc
+++ b/chrome/browser/extensions/api/socket/socket.cc
@@ -87,6 +87,17 @@ bool Socket::SetNoDelay(bool no_delay) {
return false;
}
+int Socket::Listen(const std::string& address, int port, int backlog,
+ std::string* error_msg) {
+ NOTREACHED();
+ return net::ERR_NOT_IMPLEMENTED;
miket_OOO 2012/09/26 17:17:55 See comments in earlier patch. I retract my reques
justinlin 2012/09/26 20:53:12 Done.
+}
+
+void Socket::Accept(const AcceptCompletionCallback& callback) {
+ NOTREACHED();
+ callback.Run(net::ERR_NOT_IMPLEMENTED, NULL);
miket_OOO 2012/09/26 17:17:55 Same as above.
justinlin 2012/09/26 20:53:12 Done.
+}
+
// static
bool Socket::StringAndPortToIPEndPoint(const std::string& ip_address_str,
int port,

Powered by Google App Engine
This is Rietveld 408576698