Implement chrome.socket.bind/listen/accept for TCP server socket.

chrome/browser/extensions/api/socket/socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/socket.h"
 
 #include "base/bind.h"
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 #include "net/base/address_list.h"
 #include "net/base/io_buffer.h"
@@ skipping 69 matching lines @@
 }
 
 bool Socket::SetKeepAlive(bool enable, int delay) {
   return false;
 }
 
 bool Socket::SetNoDelay(bool no_delay) {
   return false;
 }
 
+int Socket::Listen(const std::string& address, int port, int backlog,
+                   std::string* error_msg) {

[miket_OOO, 2012/09/24 18:14:21]

Can you put NOTREACHED in here? I think we want to die loudly if this happens.

[justinlin, 2012/09/26 08:59:59]

Done. This will happen if you try to call listen/accept on a UDP socket though.

[miket_OOO, 2012/09/26 17:17:55]

Oh, OK, then my request was in error. NOTREACHED is like a runtime assertion --
if it gets here, our code is bad. If a user can legitimately (if erroneously)
get here, then it should return an error rather than killing the process.

I think, though, that ERR_NOT_IMPLEMENTED might not be exactly the right code to
return. It's more like an invalid state or an invalid request, rather than
something we haven't gotten around to implementing yet. (If you think
NOT_IMPLEMENTED represents the right sentiment, then it's OK to leave as-is.)

[justinlin, 2012/09/26 20:53:12]

Done. Yea, I agree NOT_IMPLEMENTED might not be the right error here. I changed
it to net::FAILED to just match what we do for TCP bind (which is not supported
either).

+  return net::ERR_NOT_IMPLEMENTED;
+}
+
+void Socket::Accept(const AcceptCompletionCallback& callback) {
+  callback.Run(net::ERR_NOT_IMPLEMENTED, NULL);

[miket_OOO, 2012/09/24 18:14:21]

Same.

[justinlin, 2012/09/26 08:59:59]

Done.

+}
+
 // static
 bool Socket::StringAndPortToIPEndPoint(const std::string& ip_address_str,
                                        int port,
                                        net::IPEndPoint* ip_end_point) {
   DCHECK(ip_end_point);
   net::IPAddressNumber ip_number;
   if (!net::ParseIPLiteralToNumber(ip_address_str, &ip_number))
     return false;
 
   *ip_end_point = net::IPEndPoint(ip_number, port);
@@ skipping 30 matching lines @@
                                    const CompletionCallback& callback)
     : io_buffer(io_buffer),
       byte_count(byte_count),
       callback(callback),
       bytes_written(0) {
 }
 
 Socket::WriteRequest::~WriteRequest() { }
 
 }  // namespace extensions