Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 10827363: Add Linux Host builds to NaCl SDK (Closed)

Created:
8 years, 4 months ago by noelallen1
Modified:
8 years, 4 months ago
Reviewers:
binji
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add Linux Host builds to NaCl SDK Add the ability to build and run Linux host changes. Add the ability to specify which version of the example to run. Prints a warning the TOOLCHAIN and/or CONFIG specified are invalid. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151964

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -20 lines) Patch
M native_client_sdk/src/build_tools/generate_make.py View 2 chunks +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/make_rules.py View 1 5 chunks +15 lines, -18 lines 0 comments Download
M native_client_sdk/src/build_tools/template.mk View 1 chunk +10 lines, -2 lines 0 comments Download
M native_client_sdk/src/examples/common.js View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
noelallen1
8 years, 4 months ago (2012-08-15 23:30:32 UTC) #1
binji
lgtm http://codereview.chromium.org/10827363/diff/1/native_client_sdk/src/build_tools/make_rules.py File native_client_sdk/src/build_tools/make_rules.py (right): http://codereview.chromium.org/10827363/diff/1/native_client_sdk/src/build_tools/make_rules.py#newcode362 native_client_sdk/src/build_tools/make_rules.py:362: text ='PPAPI_<CONFIG>:=$(abspath %s)' % plugin nit: remove extra ...
8 years, 4 months ago (2012-08-16 00:17:52 UTC) #2
noelallen1
http://codereview.chromium.org/10827363/diff/1/native_client_sdk/src/build_tools/make_rules.py File native_client_sdk/src/build_tools/make_rules.py (right): http://codereview.chromium.org/10827363/diff/1/native_client_sdk/src/build_tools/make_rules.py#newcode362 native_client_sdk/src/build_tools/make_rules.py:362: text ='PPAPI_<CONFIG>:=$(abspath %s)' % plugin On 2012/08/16 00:17:52, binji ...
8 years, 4 months ago (2012-08-16 17:58:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelallen@chromium.org/10827363/4001
8 years, 4 months ago (2012-08-16 18:40:06 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 21:02:30 UTC) #5
Change committed as 151964

Powered by Google App Engine
This is Rietveld 408576698