Changed AudioPacket data to a repeated field.

remoting/client/plugin/pepper_audio_player.cc

Index: remoting/client/plugin/pepper_audio_player.cc
diff --git a/remoting/client/plugin/pepper_audio_player.cc b/remoting/client/plugin/pepper_audio_player.cc
index 44487707402520b67739243656f5d0a7177ea238..8b167d5efd27bfa1dbe2e0962cb1a394dff9454d 100644
--- a/remoting/client/plugin/pepper_audio_player.cc
+++ b/remoting/client/plugin/pepper_audio_player.cc
@@ -74,7 +74,14 @@ bool PepperAudioPlayer::ResetAudioPlayer(
 void PepperAudioPlayer::ProcessAudioPacket(scoped_ptr<AudioPacket> packet) {
   // TODO(kxing): Limit the size of the queue so that latency doesn't grow
   // too large.
-  if (packet->data().size() % (kChannels * kSampleSizeBytes) != 0) {
+
+  // Drop null packets.
+  if (!packet.get())
+    return;
+
+  DCHECK_EQ(1, packet->data_size());

[Sergey Ulanov, 2012/08/15 17:38:10]

Actually I meant that we need CHECK() here, but DCHECK() for encoding(). If
encoding() is not set to ENCODING_RAW - nothing horrible is going to happen, we
would just play some noise. If there is no data in the packet then we may end up
accessing memory at some random address when we use data(0). This potentially
could lead to a security vulnerability. It's not a big problem in this
particular case because we don't write anything to packet->data(0), still it's
better to be safe.

[kxing, 2012/08/15 18:41:55]

Done.

+  DCHECK_EQ(AudioPacket::ENCODING_RAW, packet->encoding());
+  if (packet->data(0).size() % (kChannels * kSampleSizeBytes) != 0) {
     LOG(WARNING) << "Received corrupted packet.";
     return;
   }
@@ -129,14 +136,14 @@ void PepperAudioPlayer::FillWithSamples(void* samples, uint32_t buffer_size) {
     }
 
     // Pop off the packet if we've already consumed all its bytes.
-    if (queued_packets_.front()->data().size() == bytes_consumed_) {
+    if (queued_packets_.front()->data(0).size() == bytes_consumed_) {
       delete queued_packets_.front();
       queued_packets_.pop_front();
       bytes_consumed_ = 0;
       continue;
     }
 
-    const std::string& packet_data = queued_packets_.front()->data();
+    const std::string& packet_data = queued_packets_.front()->data(0);
     size_t bytes_to_copy = std::min(
         packet_data.size() - bytes_consumed_,
         bytes_needed - bytes_extracted);