remoting/codec/audio_encoder_verbatim.cc - Issue 10827324: Changed AudioPacket data to a repeated field.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/codec/audio_encoder_verbatim.cc

Issue 10827324: Changed AudioPacket data to a repeated field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/codec/audio_encoder_verbatim.h"	5 #include "remoting/codec/audio_encoder_verbatim.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "remoting/proto/audio.pb.h"	8 #include "remoting/proto/audio.pb.h"

9	9

10 namespace remoting {	10 namespace remoting {

11	11

12 AudioEncoderVerbatim::AudioEncoderVerbatim() {}	12 AudioEncoderVerbatim::AudioEncoderVerbatim() {}

13	13

14 AudioEncoderVerbatim::~AudioEncoderVerbatim() {}	14 AudioEncoderVerbatim::~AudioEncoderVerbatim() {}

15	15

16 scoped_ptr<AudioPacket> AudioEncoderVerbatim::Encode(	16 scoped_ptr<AudioPacket> AudioEncoderVerbatim::Encode(

17 scoped_ptr<AudioPacket> packet) {	17 scoped_ptr<AudioPacket> packet) {

18 DCHECK_EQ(AudioPacket::ENCODING_RAW, packet->encoding());	18 DCHECK_EQ(AudioPacket::ENCODING_RAW, packet->encoding());

	19 DCHECK_EQ(1, packet->data_size());
	Sergey Ulanov 2012/08/14 18:50:05 Can you please modify decoder too? On the decoder Can you please modify decoder too? On the decoder side we need to drop invalid packets instead of DCHECK'ing. kxing 2012/08/14 20:56:15 Done. Show quoted text On 2012/08/14 18:50:05, sergeyu wrote: > Can you please modify decoder too? On the decoder side we need to drop invalid > packets instead of DCHECK'ing. Done.
19 return packet.Pass();	20 return packet.Pass();

20 }	21 }

21	22

22 } // namespace remoting	23 } // namespace remoting

OLD	NEW