Propagate the result of AmountOfFreeSpace to JS and show it in chrome://drive-internals.

chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/drive_internals_ui.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/stringprintf.h"
 #include "base/memory/weak_ptr.h"
+#include "base/path_service.h"
+#include "base/sys_info.h"
 #include "chrome/browser/chromeos/gdata/gdata.pb.h"
 #include "chrome/browser/chromeos/gdata/gdata_auth_service.h"
 #include "chrome/browser/chromeos/gdata/gdata_cache.h"
 #include "chrome/browser/chromeos/gdata/gdata_documents_service.h"
 #include "chrome/browser/chromeos/gdata/gdata_file_system_interface.h"
 #include "chrome/browser/chromeos/gdata/gdata_system_service.h"
 #include "chrome/browser/chromeos/gdata/gdata_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
 #include "chrome/common/url_constants.h"
@@ skipping 168 matching lines @@
       "pageLoaded",
       base::Bind(&DriveInternalsWebUIHandler::OnPageLoaded,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 gdata::GDataSystemService* DriveInternalsWebUIHandler::GetSystemService() {
   Profile* profile = Profile::FromWebUI(web_ui());
   return gdata::GDataSystemServiceFactory::GetForProfile(profile);
 }
 
 void DriveInternalsWebUIHandler::OnPageLoaded(const base::ListValue* args) {

[satorux1, 2012/08/13 07:26:20]

Please add the following here followed by a blank line, and other functions too

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

[Haruki Sato, 2012/08/17 05:46:34]

Done.

   gdata::GDataSystemService* system_service = GetSystemService();
   // |system_service| may be NULL in the guest/incognito mode.
   if (!system_service)
     return;
 
   gdata::DocumentsServiceInterface* documents_service =
       system_service->docs_service();
   DCHECK(documents_service);
 
   // Update the auth status section.
   base::DictionaryValue auth_status;
   auth_status.SetBoolean("has-refresh-token",
                          documents_service->HasRefreshToken());
   auth_status.SetBoolean("has-access-token",
                          documents_service->HasAccessToken());
   web_ui()->CallJavascriptFunction("updateAuthStatus", auth_status);
 
+  // Propagate the amount of local free space in bytes.
+  FilePath path;
+  int64 free_space = -1;
+  if (PathService::Get(base::DIR_HOME, &path)) {
+    free_space = base::SysInfo::AmountOfFreeDiskSpace(path);

[satorux1, 2012/08/13 07:26:20]

I think we shouldn't do this on UI thread. We should post a task to a blocking
pool. Please see some example in chrome/browser/chromeos/gdata.

Looking at the code, AmountOfFreeDiskSpace does not have 

  base::ThreadRestrictions::AssertIOAllowed();

I think we should add it, as it'll likely access the disk. Could you add it in a
separate patch?

[Haruki Sato, 2012/08/17 05:46:34]

Done.
and moved the code to have more cleaner structure.
PTAL.

Also I filed http://crbug.com/143335 and will work on it.

+  } else {
+    LOG(ERROR) << "Home directory not found";
+  }
+  base::DictionaryValue local_storage_summary;
+  local_storage_summary.SetDouble("free_space", free_space);
+  web_ui()->CallJavascriptFunction(
+      "updateLocalStorageUsage", local_storage_summary);
+
+
   // Start updating the GCache contents section.
   Profile* profile = Profile::FromWebUI(web_ui());
   const FilePath root_path =
       gdata::GDataCache::GetCacheRootPath(profile);
   base::ListValue* gcache_contents = new ListValue;
   base::DictionaryValue* gcache_summary = new DictionaryValue;
   content::BrowserThread::PostBlockingPoolTaskAndReply(
       FROM_HERE,
       base::Bind(&GetGCacheContents,
                  root_path,
@@ skipping 117 matching lines @@
       new ChromeWebUIDataSource(chrome::kChromeUIDriveInternalsHost);
   source->add_resource_path("drive_internals.css", IDR_DRIVE_INTERNALS_CSS);
   source->add_resource_path("drive_internals.js", IDR_DRIVE_INTERNALS_JS);
   source->set_default_resource(IDR_DRIVE_INTERNALS_HTML);
 
   Profile* profile = Profile::FromWebUI(web_ui);
   ChromeURLDataManager::AddDataSource(profile, source);
 }
 
 }  // namespace chromeos