chrome/common/extensions/extension_switch_utils.h - Issue 10827268: Added flag --extensions-in-action-box to split Action Box and Extensions in it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/extension_switch_utils.h

Issue 10827268: Added flag --extensions-in-action-box to split Action Box and Extensions in it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_SWITCH_UTILS_H_	5 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_SWITCH_UTILS_H_

6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_SWITCH_UTILS_H_	6 #define CHROME_COMMON_EXTENSIONS_EXTENSION_SWITCH_UTILS_H_

7	7

8 namespace extensions {	8 namespace extensions {

9	9

10 namespace switch_utils {	10 namespace switch_utils {

11	11

12 bool IsEasyOffStoreInstallEnabled();	12 bool IsEasyOffStoreInstallEnabled();

13	13

14 bool IsActionBoxEnabled();	14 bool IsActionBoxEnabled();
	not at google - send to devlin 2012/08/14 04:09:53 do extensions care about this flag any more? Perha do extensions care about this flag any more? Perhaps we should remove it so that developers don't call it rather than IsExtensionsInActionBoxEnabled by accident. yefimt 2012/08/14 20:59:07 It is still used in location_bar_view Show quoted text On 2012/08/14 04:09:53, kalman wrote: > do extensions care about this flag any more? Perhaps we should remove it so that > developers don't call it rather than IsExtensionsInActionBoxEnabled by accident. It is still used in location_bar_view not at google - send to devlin 2012/08/14 22:03:54 Yes but it's not really a concern of extensions in Show quoted text On 2012/08/14 20:59:07, yefimt wrote: > On 2012/08/14 04:09:53, kalman wrote: > > do extensions care about this flag any more? Perhaps we should remove it so > that > > developers don't call it rather than IsExtensionsInActionBoxEnabled by > accident. > > It is still used in location_bar_view Yes but it's not really a concern of extensions in location_bar_view, but a general concern of the UI. So I'm not sure if it should be in extension_switch_utils.h
15	15

	16 bool IsExtensionsInActionBoxEnabled();

	17

16 bool AreScriptBadgesEnabled();	18 bool AreScriptBadgesEnabled();

17	19

18 } // switch_utils	20 } // switch_utils

19	21

20 } // extensions	22 } // extensions

21	23

22 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_SWITCH_UTILS_H_	24 #endif // CHROME_COMMON_EXTENSIONS_EXTENSION_SWITCH_UTILS_H_

OLD	NEW

« chrome/browser/extensions/extension_prefs.cc ('K') | « chrome/common/chrome_switches.cc ('k') | chrome/common/extensions/extension_switch_utils.cc » ('j') | no next file with comments »