chrome/browser/chromeos/gdata/gdata_test_util.h - Issue 10827211: Replace GDataDirectory::TakeEntry with GDataDirectoryService::AddEntryToDirectory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_test_util.h

Issue 10827211: Replace GDataDirectory::TakeEntry with GDataDirectoryService::AddEntryToDirectory. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: renames as per feedback Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/gdata/gdata_files_unittest.cc ('K') | « chrome/browser/chromeos/gdata/gdata_files_unittest.cc ('k') | chrome/browser/chromeos/gdata/gdata_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_test_util.h

===================================================================

--- chrome/browser/chromeos/gdata/gdata_test_util.h (revision 150627)

+++ chrome/browser/chromeos/gdata/gdata_test_util.h (working copy)

@@ -9,6 +9,8 @@

#include "chrome/browser/chromeos/gdata/gdata_errorcode.h"

#include "chrome/browser/chromeos/gdata/gdata_files.h"

+class FilePath;

namespace gdata {

class GDataEntryProto;

@@ -44,9 +46,15 @@

// Copies |error| to |output|. Used to run asynchronous functions that take

// FileOperationCallback from tests.

-void CopyErrorCodeFromFileOperationCallback(

- GDataFileError* output, GDataFileError error);

+void CopyErrorCodeFromFileOperationCallback(GDataFileError* output,

+ GDataFileError error);

+// Copies |error| to |output|. Used to run asynchronous functions that take

+// FileMoveCallback from tests.

+void CopyErrorCodeFromFileMoveCallback(GDataFileError* output,

satorux1 2012/08/09 00:26:24 I think we should also copy the path. See my comme

achuithb 2012/08/09 01:41:32 Done.

+ GDataFileError error,

+ const FilePath& updated_file_path);

satorux1 2012/08/09 00:26:24 moved_file_path

achuithb 2012/08/09 01:41:32 Replaced here and elsewhere.

// respectively. Used to run asynchronous functions that take

// GetEntryInfoCallback from tests.