Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: chrome/browser/download/download_status_updater.h

Issue 10827207: Mountain Lion: use the system download progress. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_status_updater.h
diff --git a/chrome/browser/download/download_status_updater.h b/chrome/browser/download/download_status_updater.h
index 252be03d391b00c8ee9881e2563d28be87b9c019..75218c50a24e7dfddc304a2af38d343fc9ba959e 100644
--- a/chrome/browser/download/download_status_updater.h
+++ b/chrome/browser/download/download_status_updater.h
@@ -42,12 +42,16 @@ class DownloadStatusUpdater
virtual void OnDownloadDestroyed(content::DownloadItem* download) OVERRIDE;
protected:
- // Update the app icon. Virtual to be overridable for testing.
- virtual void UpdateAppIconDownloadProgress();
+ // Platform-specific function to update the platform UI for download progress.
+ // |download| is the download item that changed. Implementations should not
+ // hold the value of |download| as it is not guaranteed to remain valid.
+ // Virtual to be overridable for testing.
+ virtual void UpdateAppIconDownloadProgress(content::DownloadItem* download);
private:
- // Update the internal state tracking an item.
- void UpdateItem(content::DownloadItem* download);
+ // Update the internal state tracking an item. Returns true if the item was
+ // added to the set of tracked items.
+ bool UpdateItem(content::DownloadItem* download);
std::set<content::DownloadManager*> managers_;
std::set<content::DownloadItem*> items_;

Powered by Google App Engine
This is Rietveld 408576698