Mountain Lion: use the system download progress.

chrome/browser/download/download_status_updater_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "chrome/browser/download/download_status_updater.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/mock_download_manager.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 
 using ::testing::AtLeast;
 using ::testing::Mock;
 using ::testing::Return;
 using ::testing::SetArgPointee;
 using ::testing::StrictMock;
 using ::testing::_;
 
 class TestDownloadStatusUpdater : public DownloadStatusUpdater {
  protected:
-  virtual void UpdateAppIconDownloadProgress() OVERRIDE {
+  virtual void UpdateAppIconDownloadProgress(
+      content::DownloadItem* download) OVERRIDE {

[Randy Smith (Not in Mondays), 2012/08/10 18:38:44]

Shouldn't you add a test to make sure the right download item is passed in some
variety of circumstances?

     return;
   }
 };
 
 class DownloadStatusUpdaterTest : public testing::Test {
  public:
   DownloadStatusUpdaterTest()
       : updater_(new TestDownloadStatusUpdater()),
         ui_thread_(content::BrowserThread::UI, &loop_) {}
 
@@ skipping 76 matching lines @@
   content::MockDownloadItem* Item(int manager_index, int item_index) {
     DCHECK_GT(manager_items_.size(), static_cast<size_t>(manager_index));
     DCHECK_GT(manager_items_[manager_index].size(),
               static_cast<size_t>(item_index));
     // All DownloadItems in manager_items_ are MockDownloadItems.
     return static_cast<content::MockDownloadItem*>(
         manager_items_[manager_index][item_index]);
   }
 
   // Set return values relevant to |DownloadStatusUpdater::GetProgress()|
-  // for the specified item
+  // for the specified item.
   void SetItemValues(int manager_index, int item_index,
                      int received_bytes, int total_bytes) {
     EXPECT_CALL(*Item(manager_index, item_index), GetReceivedBytes())
         .WillRepeatedly(Return(received_bytes));
     EXPECT_CALL(*Item(manager_index, item_index), GetTotalBytes())
         .WillRepeatedly(Return(total_bytes));
   }
 
   // Transition specified item to completed.
   void CompleteItem(int manager_index, int item_index) {
@@ skipping 145 matching lines @@
   SetItemValues(0, 0, 10, 20);
   SetItemValues(0, 1, 50, 60);
   SetItemValues(1, 0, 80, 90);
 
   float progress = -1;
   int download_count = -1;
   EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
   EXPECT_FLOAT_EQ((10+50+80)/(20.0f+60+90), progress);
   EXPECT_EQ(3, download_count);
 }