chrome/browser/ui/views/browser_actions_container.cc - Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_actions_container.cc

Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_action_view.cc ('K') | « chrome/browser/ui/views/browser_action_view.cc ('k') | chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc » ('j') | chrome/common/extensions/extension_action.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_actions_container.cc

diff --git a/chrome/browser/ui/views/browser_actions_container.cc b/chrome/browser/ui/views/browser_actions_container.cc

index 9508b0acaf43113be736a657afe31a4c3ae8073f..6b4caa8c5f59aaf530b218ae00ef5bfaf20da2a1 100644

--- a/chrome/browser/ui/views/browser_actions_container.cc

+++ b/chrome/browser/ui/views/browser_actions_container.cc

@@ -403,9 +403,9 @@ void BrowserActionsContainer::WriteDragDataForView(View* sender,

BrowserActionButton* button = browser_action_views_[i]->button();

if (button == sender) {

// Set the dragging image for the icon.

- scoped_ptr<gfx::Canvas> canvas(

- browser_action_views_[i]->GetIconWithBadge());

- drag_utils::SetDragImageOnDataObject(*canvas, button->size(), press_pt,

+ // scoped_ptr<gfx::Canvas> canvas(

pkotwicz 2012/08/07 22:31:22 Nit: remove this

tbarzic 2012/08/08 02:09:29 yeah, I missed that while cleaning up the cl..

+ gfx::ImageSkia badge(browser_action_views_[i]->GetIconWithBadge());

+ drag_utils::SetDragImageOnDataObject(badge, button->size(), press_pt,

data);

// Fill in the remaining info.