chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc - Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 10827191: Convert extension action icons code to use ImageSkia instead of SkBitmap (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

diff --git a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

index 6f5fcd3d3058a245d248d351a99eecd8504f555f..77a93af585ad9be2e552c60eab4f5f78aa087fee 100644

--- a/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

+++ b/chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

@@ -249,9 +249,9 @@ class BrowserActionButton : public content::NotificationObserver,

gtk_widget_queue_draw(button());

}

- SkBitmap GetIcon() {

+ gfx::ImageSkia GetIcon() {

return *extension_->browser_action()->GetIcon(

- toolbar_->GetCurrentTabId()).ToSkBitmap();

+ toolbar_->GetCurrentTabId()).ToImageSkia();

}

MenuGtk* GetContextMenu() {

« no previous file with comments | « no previous file | chrome/browser/ui/views/browser_action_view.h » ('j') | chrome/common/extensions/extension_action.cc » ('J')