Collect call site information and use that for estimating parameter types

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 1713 matching lines @@
 
       // TODO(ahe): The constructor name was statically resolved in
       // SsaBuilder.buildFactory. Is there a cleaner way to do this?
       node.name.printOn(buffer);
       visitArguments(node.inputs);
     } else {
       buffer.add(compiler.namer.instanceMethodInvocationName(
           currentLibrary, node.name, node.selector));
       visitArguments(node.inputs);
       bool inLoop = node.block.enclosingLoopHeader !== null;
+
+      // Register this invocation to collect the types used at all call sites.
+      // TODO(sgjesse): Should specific functions be handled better than just
+      // through their selector?

[floitsch, 2012/08/06 15:01:06]

Example?

[Søren Gjesse, 2012/08/07 09:06:03]

I couldn't find one, so I removed the TODO.

+      Selector selector = getOptimizedSelectorFor(node, node.selector);
+      backend.registerDynamicInvocation(node, selector);
+
       if (node.element !== null) {
         // If we know we're calling a specific method, register that
         // method only.
-        if (inLoop) {
-          backend.builder.functionsCalledInLoop.add(node.element);
-        }
+        if (inLoop) backend.builder.functionsCalledInLoop.add(node.element);
         world.registerDynamicInvocationOf(node.element);
       } else {
-        Selector selector = getOptimizedSelectorFor(node, node.selector);
+        if (inLoop) backend.builder.selectorsCalledInLoop[node.name] = selector;
         world.registerDynamicInvocation(node.name, selector);
-        if (inLoop) backend.builder.selectorsCalledInLoop[node.name] = selector;
       }
     }
     endExpression(JSPrecedence.CALL_PRECEDENCE);
   }
 
   Selector getOptimizedSelectorFor(HInvoke node, Selector defaultSelector) {
     Type receiverType = node.inputs[0].propagatedType.computeType(compiler);
     if (receiverType !== null) {
       return new TypedSelector(receiverType, defaultSelector);
     } else {
@@ skipping 1428 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }