[cros] OOBE slide animation.

[cros] OOBE slide animation.

Also some OOBE polishing:
*) fixed (top: 0) position for body to prevent scrolling;
*) oobe.html/login.html made structure elements.
*) 2x icons for user image screen.


BUG=129799, 139169, 141558, 141560
TBR=jhawkins
(for browser_resources.grd)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151116

[Nikita (slow), 2012-08-10 08:43:21]

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/display_manager.js (left):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/display_manager.js:194: if
(this.isNewOobe()) {
Please leave support for this flag for now.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/display_manager.js:235: // TODO(ivankr):
initial animation.
Could you please add it as a part of this CL if possible.

Btw, I figured out that we for OOBE we need to postpone WebUI not initilize it
hidden so that this first animation could be seen.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/display_manager.js:324: for (var j = 0,
screen2; screen2 = $(screenGroup[j]); j++) {
We might as well cache these max values.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.css (left):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:86: height: 294px;
Could you please move this to [oobe=old] #inner-container.

And check that OOBE flow works fine with --disable-new-oobe.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:92: -webkit-transform:
perspective(500px);
What do we need this for?

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:705: /* Don't grey out disabled
buttons. */
But that would break "Continue" button behavior, right?

When we don't have network connected it should be grayed out / disabled.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.js (right):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.js:256: showOobe = true;
Cleanup?

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.js:267:
Oobe.getInstance().showScreen({'id': 'connect'});
Cleanup?

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.html (left):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.html:16:
src="chrome://theme/IDR_LOGIN_DEFAULT_USER">
Why it is being removed?

[Ivan Korotkov, 2012-08-10 10:12:41]

Added fixes and stack-up animation, will test with old-oobe soon.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/display_manager.js (left):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/display_manager.js:194: if
(this.isNewOobe()) {
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> Please leave support for this flag for now.

Done.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/display_manager.js:235: // TODO(ivankr):
initial animation.
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> Could you please add it as a part of this CL if possible.
> 
> Btw, I figured out that we for OOBE we need to postpone WebUI not initilize it
> hidden so that this first animation could be seen.

Done.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:92: -webkit-transform:
perspective(500px);
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> What do we need this for?

Hm, we dont', actually. We need for an outer container for initial animation.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:705: /* Don't grey out disabled
buttons. */
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> But that would break "Continue" button behavior, right?
> 
> When we don't have network connected it should be grayed out / disabled.

Right, fixed.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.js (right):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.js:256: showOobe = true;
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> Cleanup?

Done.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.js:267:
Oobe.getInstance().showScreen({'id': 'connect'});
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> Cleanup?

Done.

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.html (left):

http://codereview.chromium.org/10827169/diff/8002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.html:16:
src="chrome://theme/IDR_LOGIN_DEFAULT_USER">
On 2012/08/10 08:43:21, Nikita Kostylev wrote:
> Why it is being removed?

Same reason as in Change Picture: now that it's processed with grit, we don't
want it adding -webkit-image-set statically.

[Nikita (slow), 2012-08-10 10:21:35]

lgtm

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:238: //
$('outer-container').hidden = false;
Is this commented code needed?

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:239:
$('inner-container').classList.remove('down');
This won't affect boot into user pods or boot into GAIA, right?

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:240:
console.error('Down');
Cleanup.

[Ivan Korotkov, 2012-08-10 13:25:16]

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
File chrome/browser/resources/chromeos/login/display_manager.js (right):

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:238: //
$('outer-container').hidden = false;
On 2012/08/10 10:21:35, Nikita Kostylev wrote:
> Is this commented code needed?

Removed.

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:239:
$('inner-container').classList.remove('down');
On 2012/08/10 10:21:35, Nikita Kostylev wrote:
> This won't affect boot into user pods or boot into GAIA, right?

Right, because login.html doesn't have 'down' already.

http://codereview.chromium.org/10827169/diff/14002/chrome/browser/resources/c...
chrome/browser/resources/chromeos/login/display_manager.js:240:
console.error('Down');
On 2012/08/10 10:21:35, Nikita Kostylev wrote:
> Cleanup.

Done.

[Ivan Korotkov, 2012-08-10 15:31:04]

Adding jhawkins@ for OWNERS

[Ivan Korotkov, 2012-08-10 20:15:20]

Adding jhawkins@ as TBR for browser_resources.grd

[commit-bot: I haz the power, 2012-08-10 20:25:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/10827169/4022

[commit-bot: I haz the power, 2012-08-10 20:26:17]

Presubmit check for 10827169-4022 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1257, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1105, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1022, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 44, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 93, in RunChecks
    width, height = ImageSize(image_path)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

[Ivan Korotkov, 2012-08-10 20:29:45]

Looks like presubmit tries to check a PNG file which is not included in diff.

[Nikita (slow), 2012-08-10 20:31:59]

I guess it now checks all images in oobe.html/login.html

[James Hawkins, 2012-08-10 21:17:50]

LGTM