diagnostics: Add connectivity section to chrome://diagnostics

diagnostics: Add connectivity section to chrome://diagnostics

BUG=139442
TEST=chrome://diagnostics

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150141

[hshi1, 2012-08-03 02:42:59]

Hi James, please take a look. Thanks!

This is related to an earlier patch that you reviewed
(http://codereview.chromium.org/10836039/). The current patch lands the
first-cut implementation of the main.css and main.js files, and also adds these
two files to the browser_resources.grd.

[James Hawkins, 2012-08-06 16:05:39]

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/diagnostics/main.css (right):

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/diagnostics/main.css:22: content: ' ';
s/' '/''/

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/diagnostics/main.js (right):

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/diagnostics/main.js:14: var name_element =
document.createElement('h2');
s/name_element/nameElement/

Here and elsewhere.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/diagnostics/main.js:23: } else if (typeof
deviceStatus.flags == 'undefined' ||
Just use !deviceStatus.flags.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc (right):

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc:45: // Called
when GetNetworkInterfaces() is complete.
nit: Document parameters.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc:71: const
std::string& status) {
Optional nit: This parameter can fit on the line above (to save lines).

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc:72: if
(succeeded) {
Optional nit: Reverse the logic and return early to save indentation.

[hshi1, 2012-08-06 17:30:55]

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/diagnostics/main.css (right):

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/diagnostics/main.css:22: content: ' ';
On 2012/08/06 16:05:39, James Hawkins wrote:
> s/' '/''/

Done.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/diagnostics/main.js (right):

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/diagnostics/main.js:14: var name_element =
document.createElement('h2');
On 2012/08/06 16:05:39, James Hawkins wrote:
> s/name_element/nameElement/
> 
> Here and elsewhere.

Done.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/diagnostics/main.js:23: } else if (typeof
deviceStatus.flags == 'undefined' ||
On 2012/08/06 16:05:39, James Hawkins wrote:
> Just use !deviceStatus.flags.

Done.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc (right):

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc:45: // Called
when GetNetworkInterfaces() is complete.
On 2012/08/06 16:05:39, James Hawkins wrote:
> nit: Document parameters.

Done.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc:71: const
std::string& status) {
On 2012/08/06 16:05:39, James Hawkins wrote:
> Optional nit: This parameter can fit on the line above (to save lines).

Done.

http://codereview.chromium.org/10827148/diff/5003/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc:72: if
(succeeded) {
On 2012/08/06 16:05:39, James Hawkins wrote:
> Optional nit: Reverse the logic and return early to save indentation.

Done.

[James Hawkins, 2012-08-06 17:33:56]

lgtm

[commit-bot: I haz the power, 2012-08-06 18:18:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/10827148/9012