crbug.com/127841 - Request Tablet Site on CB with touch screen.

webkit/glue/user_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/user_agent.h"
 
 #if defined(OS_POSIX) && !defined(OS_MACOSX)
 #include <sys/utsname.h>
 #endif
 
 #include "base/lazy_instance.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/sys_info.h"
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #endif
 
 // Generated
 #include "webkit_version.h"  // NOLINT
 
+namespace {
+const char kOsOverrideForTabletSite[] = "Linux; Android";

[gone, 2012/09/06 18:08:32]

Change this to "Linux; Android 4.0.3" as per the email with klobag; websites
might try to grep for the Android version.  Not sure if this is the right place
to put this, though, and I don't think we should be adding a new function for it
if it's only called from one place.

[sschmitz, 2012/09/06 18:52:45]

Ok, thanks for your dilligence on this.
Done.

+}
+
 namespace webkit_glue {
 
 std::string GetWebKitVersion() {
   return base::StringPrintf("%d.%d (%s)",
                             WEBKIT_VERSION_MAJOR,
                             WEBKIT_VERSION_MINOR,
                             WEBKIT_SVN_REVISION);
 }
 
 std::string GetWebKitRevision() {
@@ skipping 139 matching lines @@
       "Mozilla/5.0 (%s) AppleWebKit/%d.%d (KHTML, like Gecko) %s Safari/%d.%d",
       os_info.c_str(),
       WEBKIT_VERSION_MAJOR,
       WEBKIT_VERSION_MINOR,
       product.c_str(),
       WEBKIT_VERSION_MAJOR,
       WEBKIT_VERSION_MINOR);
   return user_agent;
 }
 
+std::string BuildUserAgentOverrideForTabletSiteFromProduct(
+    const std::string& product)
+{

[gone, 2012/09/06 18:08:32]

Brace needs to go on the previous line.

[sschmitz, 2012/09/06 18:52:45]

Old habits die hard ;-)
Done

+  return BuildUserAgentFromOSAndProduct(kOsOverrideForTabletSite,
+                                        product);
+}
+
 }  // namespace webkit_glue