Refactoring the SysInfoProvider.

chrome/browser/chromeos/system_logs/memorydetails_log_source.cc

Index: chrome/browser/chromeos/system_logs/memorydetails_log_source.cc
diff --git a/chrome/browser/chromeos/system_logs/memorydetails_log_source.cc b/chrome/browser/chromeos/system_logs/memorydetails_log_source.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6195303c1dfbf4a11bab8e9d5ec3b98c42b53536
--- /dev/null
+++ b/chrome/browser/chromeos/system_logs/memorydetails_log_source.cc
@@ -0,0 +1,45 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/system_logs/memorydetails_log_source.h"
+
+#include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
+#include "chrome/browser/memory_details.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace chromeos {
+
+class SysLogsFetcherMemoryHandler : public MemoryDetails {

[satorux1, 2012/08/16 10:50:57]

class comment is missing.

[tudalex(Chromium), 2012/08/16 22:33:03]

Done.

+ public:
+  SysLogsFetcherMemoryHandler(
+      SysLogsFetcherCallback callback)

[satorux1, 2012/08/16 10:50:57]

move this to the previous line.

[tudalex(Chromium), 2012/08/16 22:33:03]

Done.

+      : callback_(callback) {}
+
+  // MemoryDetails override.
+  virtual void OnDetailsAvailable() OVERRIDE {
+    DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+
+    scoped_ptr<SystemLogsResponse> response(new SystemLogsResponse);
+    (*response)["mem_usage"] = ToLogString();
+    callback_.Run(response.get());
+  }
+
+ private:
+  virtual ~SysLogsFetcherMemoryHandler() {}
+  SysLogsFetcherCallback callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(SysLogsFetcherMemoryHandler);
+};
+
+void MemoryDetailsLogSource::Fetch(const SysLogsFetcherCallback& callback) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+  DCHECK(!callback.is_null());
+
+  scoped_refptr<SysLogsFetcherMemoryHandler>
+      handler(new SysLogsFetcherMemoryHandler(callback));
+  // TODO(jamescook): Maybe we don't need to update histograms here?
+  handler->StartFetch(MemoryDetails::UPDATE_USER_METRICS);
+}
+
+}  // namespace chromeos