Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: chrome/browser/chromeos/syslogs/memorydetails_fetcher.cc

Issue 10827130: Refactoring the SysInfoProvider. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/syslogs/memorydetails_fetcher.cc
diff --git a/chrome/browser/chromeos/syslogs/memorydetails_fetcher.cc b/chrome/browser/chromeos/syslogs/memorydetails_fetcher.cc
new file mode 100644
index 0000000000000000000000000000000000000000..cb21328ed352269538577851e1a72a0b6e0db943
--- /dev/null
+++ b/chrome/browser/chromeos/syslogs/memorydetails_fetcher.cc
@@ -0,0 +1,41 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/syslogs/memorydetails_fetcher.h"
+
+#include "chrome/browser/chromeos/syslogs/syslogs_fetcher.h"
+#include "chrome/browser/memory_details.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace chromeos {
+
+class SysLogsFetcherMemoryHandler : public MemoryDetails {
+ public:
+
+ SysLogsFetcherMemoryHandler(
+ SysLogsFetcherCallback request)
+ : request_(request) {}
+
+ virtual void OnDetailsAvailable() OVERRIDE {
+ SysLogsResponse* response = new SysLogsResponse;
+ (*response)["mem_usage"] = ToLogString();
+ // This will call the callback on the calling thread.
rkc 2012/08/06 18:30:18 How?
tudalex(Chromium) 2012/08/06 19:14:22 Left comment from the SysLogsProvider code when I
+ request_.Run(response);
+ }
+
+ private:
+ virtual ~SysLogsFetcherMemoryHandler() {}
+ SysLogsFetcherCallback request_;
+
+ DISALLOW_COPY_AND_ASSIGN(SysLogsFetcherMemoryHandler);
+};
+
+void MemoryDetailsFetcher::Fetch(SysLogsFetcherCallback request){
+ scoped_refptr<SysLogsFetcherMemoryHandler>
+ handler(new SysLogsFetcherMemoryHandler(request));
+ // TODO(jamescook): Maybe we don't need to update histograms here?
+ handler->StartFetch(MemoryDetails::UPDATE_USER_METRICS);
+}
+
+} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698