Refactoring the SysInfoProvider.

chrome/browser/chromeos/system_logs/debugd_log_source.h

Index: chrome/browser/chromeos/system_logs/debugd_log_source.h
diff --git a/chrome/browser/chromeos/system_logs/debugd_log_source.h b/chrome/browser/chromeos/system_logs/debugd_log_source.h
new file mode 100644
index 0000000000000000000000000000000000000000..884a32c2466dc41c117399265682a356e4fc9315
--- /dev/null
+++ b/chrome/browser/chromeos/system_logs/debugd_log_source.h
@@ -0,0 +1,50 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_DEBUGD_LOG_SOURCE_H_
+#define CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_DEBUGD_LOG_SOURCE_H_
+
+#include <map>
+#include <string>
+#include <vector>
+
+#include "base/memory/weak_ptr.h"
+#include "chrome/browser/chromeos/system_logs/system_logs_fetcher.h"
+
+namespace chromeos {
+
+// Gathers log data from Debug Daemon.
+class DebugDaemonLogSource : public SystemLogsSource {
+ public:
+  DebugDaemonLogSource();
+  virtual ~DebugDaemonLogSource();
+
+  // Fetches logs from the daemon over dbus. After the fetch is complete, the
+  // results will be forwarded to the request supplied to the constructor and
+  // this instance will free itself.
+  // SystemLogsSource override.
+  virtual void Fetch(const SysLogsFetcherCallback& request) OVERRIDE;
+
+ private:
+  // Callbacks for the 4 different dbus calls
+  void GotRoutes(bool succeeded, const std::vector<std::string>& routes);
+  void GotNetworkStatus(bool succeeded, const std::string& status);
+  void GotModemStatus(bool succeeded, const std::string& status);
+  void GotLogs(bool succeeded, const std::map<std::string, std::string>& logs);
+  // Sends the data to the SysLogsFetcherCallback when all the requests are
+  // completed
+  void RequestCompleted();
+
+  SystemLogsResponse* response_;
+  SysLogsFetcherCallback request_;
+  int pending_requests_;

[satorux1, 2012/08/13 18:29:03]

please add num_ prefix.

[tudalex(Chromium), 2012/08/14 03:24:00]

Done.

+  base::WeakPtrFactory<DebugDaemonLogSource> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(DebugDaemonLogSource);
+};
+
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_SYSTEM_LOGS_DEBUGD_LOG_SOURCE_H_