chrome/browser/chromeos/syslogs/lsbrelease_fetcher.h - Issue 10827130: Refactoring the SysInfoProvider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/syslogs/lsbrelease_fetcher.h

Issue 10827130: Refactoring the SysInfoProvider. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/syslogs/debugd_log_fetcher.h ('K') | « chrome/browser/chromeos/syslogs/debugd_log_fetcher.cc ('k') | chrome/browser/chromeos/syslogs/lsbrelease_fetcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 #ifndef CHROME_BROWSER_CHROMEOS_SYSLOGS_LSBRELEASE_FETCHER_H_

	5 #define CHROME_BROWSER_CHROMEOS_SYSLOGS_LSBRELEASE_FETCHER_H_

	6

	7 #include "chrome/browser/chromeos/syslogs/syslogs_fetcher.h"

	8

	9 namespace chromeos {

	10

	11 class LSBReleaseFetcher : public SysLogsInterface {
	satorux1 2012/08/06 23:47:31 class comment is missing. class comment is missing. tudalex(Chromium) 2012/08/07 00:56:11 Done. Show quoted text On 2012/08/06 23:47:31, satorux1 wrote: > class comment is missing. Done.
	12 public:

	13 LSBReleaseFetcher() {}

	14 ~LSBReleaseFetcher() {}

	15

	16 void Fetch(SysLogsFetcherCallback);
	satorux1 2012/08/06 23:47:31 const SysLogsFetcherCallback& const SysLogsFetcherCallback& satorux1 2012/08/06 23:47:31 is this implementing a virtu function in SysLogsIn is this implementing a virtu function in SysLogsInterface? If so, make it virtual void Fetch(SysLogsFetcherCallback) OVERRIDE; tudalex(Chromium) 2012/08/07 00:56:11 Done. Show quoted text On 2012/08/06 23:47:31, satorux1 wrote: > is this implementing a virtu function in SysLogsInterface? If so, make it > > virtual void Fetch(SysLogsFetcherCallback) OVERRIDE; Done. tudalex(Chromium) 2012/08/07 00:56:11 Done. Show quoted text On 2012/08/06 23:47:31, satorux1 wrote: > const SysLogsFetcherCallback& Done.
	17

	18 private:

	19 DISALLOW_COPY_AND_ASSIGN(LSBReleaseFetcher);

	20 };

	21

	22 } // namespace chromeos

	23

	24 #endif // CHROME_BROWSER_CHROMEOS_SYSLOGS_LSBRELEASE_FETCHER_H_

OLD	NEW