chrome/browser/chromeos/syslogs/commandline_fetcher.h - Issue 10827130: Refactoring the SysInfoProvider.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/syslogs/commandline_fetcher.h

Issue 10827130: Refactoring the SysInfoProvider. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_CHROMEOS_SYSLOGS_COMMANDLINE_FETCHER_H_

	6 #define CHROME_BROWSER_CHROMEOS_SYSLOGS_COMMANDLINE_FETCHER_H_

	7

	8 #include "chrome/browser/chromeos/syslogs/syslogs_fetcher.h"

	9

	10 namespace chromeos {

	11

	12 class CommandLineFetcher : public SysLogsInterface {
	satorux1 2012/08/06 23:47:31 Class comment is missing. http://google-styleguid Class comment is missing. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments tudalex(Chromium) 2012/08/07 00:56:11 Done. Show quoted text On 2012/08/06 23:47:31, satorux1 wrote: > Class comment is missing. > > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Class_Comments Done.
	13 public:

	14 CommandLineFetcher() : response_(new SysLogsResponse) {}

	15 ~CommandLineFetcher() {}

	16

	17 void Fetch(SysLogsFetcherCallback);

	18

	19 private:

	20 SysLogsResponse * response_;
	satorux1 2012/08/06 23:47:31 SysLogsResponse* response_; SysLogsResponse* response_; tudalex(Chromium) 2012/08/07 00:56:11 Done. Show quoted text On 2012/08/06 23:47:31, satorux1 wrote: > SysLogsResponse* response_; Done.
	21

	22 DISALLOW_COPY_AND_ASSIGN(CommandLineFetcher);

	23 };

	24

	25 } // namespace chromeos

	26

	27 #endif // CHROME_BROWSER_CHROMEOS_SYSLOGS_COMMANDLINE_FETCHER_H_

OLD	NEW