Refactoring the SysInfoProvider.

chrome/browser/chromeos/syslogs/syslogs_fetcher_factory.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_SYSLOGS_SYSLOGS_FETCHER_FACTORY_H_
+#define CHROME_BROWSER_CHROMEOS_SYSLOGS_SYSLOGS_FETCHER_FACTORY_H_
+
+#include <string>
+#include <vector>
+
+#include "base/memory/singleton.h"
+
+namespace chromeos {
+
+class SysLogsFetcher;
+
+class SysLogsFetcherFactory {
+ public:
+    static SysLogsFetcherFactory* GetInstance();
+    SysLogsFetcher* CreateFetcher();
+
+ private:
+    SysLogsFetcherFactory()  {}
+    ~SysLogsFetcherFactory() {}
+    friend struct DefaultSingletonTraits<SysLogsFetcherFactory>;

[rkc, 2012/08/06 18:30:18]

Move the friend above the ctor/dtor, add a newline after; do this anywhere else
friend is used also.

[tudalex(Chromium), 2012/08/06 19:14:22]

Done.

+

[rkc, 2012/08/06 18:30:18]

DISALLOW_COPY_AND_ASSIGN?
friend goes right below the private: and newline after

[tudalex(Chromium), 2012/08/06 19:14:22]

Done.

+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_SYSLOGS_SYSLOGS_FETCHER_FACTORY_H_