Refactoring the SysInfoProvider.

chrome/browser/chromeos/syslogs/memorydetails_fetcher.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/syslogs/memorydetails_fetcher.h"
+
+#include "chrome/browser/chromeos/syslogs/syslogs_fetcher.h"
+#include "chrome/browser/memory_details.h"
+#include "content/public/browser/browser_thread.h"
+
+namespace chromeos {
+
+class SysLogsFetcherMemoryHandler : public MemoryDetails {
+ public:
+
+  SysLogsFetcherMemoryHandler(
+      SysLogsFetcherCallback request)
+      : request_(request) {}
+
+  virtual void OnDetailsAvailable() OVERRIDE {
+    SysLogsResponse* response = new SysLogsResponse;
+    (*response)["mem_usage"] = ToLogString();
+    content::BrowserThread::PostTask(content::BrowserThread::UI,

[satorux1, 2012/08/08 22:01:03]

Why is this needed? On what thread this function is called? Please annotate with
DCHECK

[tudalex(Chromium), 2012/08/09 02:30:24]

Not needed actually. Annotated with DCHECK.

+                                       FROM_HERE,
+                                       base::Bind(request_, response));
+  }
+
+ private:
+  virtual ~SysLogsFetcherMemoryHandler() {}
+  SysLogsFetcherCallback request_;
+
+  DISALLOW_COPY_AND_ASSIGN(SysLogsFetcherMemoryHandler);
+};
+
+void MemoryDetailsFetcher::Fetch(const SysLogsFetcherCallback& request) {
+  if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE)) {
+    content::BrowserThread::PostTask(content::BrowserThread::FILE,
+                                     FROM_HERE,
+                                     base::Bind(&MemoryDetailsFetcher::Fetch,
+                                                base::Unretained(this),

[satorux1, 2012/08/08 22:01:03]

please fix this too.

[tudalex(Chromium), 2012/08/09 02:30:24]

Not needed actually.

+                                                request));
+    return;
+  }
+  scoped_refptr<SysLogsFetcherMemoryHandler>
+      handler(new SysLogsFetcherMemoryHandler(request));
+  // TODO(jamescook): Maybe we don't need to update histograms here?
+  handler->StartFetch(MemoryDetails::UPDATE_USER_METRICS);
+}
+
+}  // namespace chromeos