Add serial bulk reads.

chrome/browser/extensions/api/serial/serial_api.cc

Index: chrome/browser/extensions/api/serial/serial_api.cc
diff --git a/chrome/browser/extensions/api/serial/serial_api.cc b/chrome/browser/extensions/api/serial/serial_api.cc
index 80a2646bb8d9063dc2d4cb0e437f6a17122f857d..f2c524747aca8bec76bab56a8c7cb9744e15bc8f 100644
--- a/chrome/browser/extensions/api/serial/serial_api.cc
+++ b/chrome/browser/extensions/api/serial/serial_api.cc
@@ -18,6 +18,7 @@ const char kConnectionIdKey[] = "connectionId";
 const char kPortsKey[] = "ports";
 const char kDataKey[] = "data";
 const char kBytesReadKey[] = "bytesRead";
+const char kBytesToReadKey[] = "bytesToRead";
 const char kBytesWrittenKey[] = "bytesWritten";
 const char kBitrateKey[] = "bitrate";
 const char kOptionsKey[] = "options";
@@ -29,6 +30,8 @@ const char kCtsKey[] = "cts";
 
 const char kErrorGetControlSignalsFailed[] = "Failed to get control signals.";
 const char kErrorSetControlSignalsFailed[] = "Failed to set control signals.";
+const char kSerialReadInvalidBytesToRead[] = "Number of bytes to read must "
+    "be a positive number.";
 
 SerialAsyncApiFunction::SerialAsyncApiFunction()
     : manager_(NULL) {
@@ -196,16 +199,22 @@ bool SerialReadFunction::Prepare() {
 
   params_ = api::experimental_serial::Read::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params_.get());
+  if (params_->bytes_to_read <= 0) {
+    error_ = kSerialReadInvalidBytesToRead;
+    return false;
+  }
 
   return true;
 }
 
 void SerialReadFunction::Work() {
-  uint8 byte = '\0';
   int bytes_read = -1;
-  SerialConnection* serial_connection = manager_->Get(params_->connection_id);
+  scoped_refptr<net::IOBufferWithSize> io_buffer(
+      new net::IOBufferWithSize(params_->bytes_to_read));

[asargent_no_longer_on_chrome, 2012/08/02 19:58:07]

nit: does IOBufferWithSize already properly handle the case of being passed an
absurdly large number of bytes? If not we should impose some reasonable upper
limit (a megabyte maybe?)

+  SerialConnection* serial_connection(manager_->Get(params_->connection_id));
+
   if (serial_connection)
-    bytes_read = serial_connection->Read(&byte);
+    bytes_read = serial_connection->Read(io_buffer);
 
   DictionaryValue* result = new DictionaryValue();
 
@@ -215,7 +224,7 @@ void SerialReadFunction::Work() {
     bytes_read = 0;
   result->SetInteger(kBytesReadKey, bytes_read);
   result->Set(kDataKey, base::BinaryValue::CreateWithCopiedBuffer(
-      reinterpret_cast<char*>(&byte), bytes_read));
+      io_buffer->data(), bytes_read));
   SetResult(result);
 }