Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/serial/serial_connection.cc

Issue 10827123: Add serial bulk reads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/serial/serial_apitest.cc ('K') | « chrome/browser/extensions/api/serial/serial_connection.h ('k') | chrome/common/extensions/api/experimental_serial.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/serial/serial_connection.cc
diff --git a/chrome/browser/extensions/api/serial/serial_connection.cc b/chrome/browser/extensions/api/serial/serial_connection.cc
index b25df0687bb4e7a8e20ad4ffe5616f53adf23fbf..6834a61eba20120bdaecf68dd7f01b5c5c7d2ddc 100644
--- a/chrome/browser/extensions/api/serial/serial_connection.cc
+++ b/chrome/browser/extensions/api/serial/serial_connection.cc
@@ -54,10 +54,11 @@ void SerialConnection::Close() {
}
}
-int SerialConnection::Read(uint8* byte) {
- DCHECK(byte);
+int SerialConnection::Read(scoped_refptr<net::IOBufferWithSize> io_buffer) {
+ DCHECK(io_buffer->data());
return base::ReadPlatformFileAtCurrentPos(file_,
- reinterpret_cast<char*>(byte), 1);
+ io_buffer->data(),
+ io_buffer->size());
}
int SerialConnection::Write(scoped_refptr<net::IOBuffer> io_buffer,
« chrome/browser/extensions/api/serial/serial_apitest.cc ('K') | « chrome/browser/extensions/api/serial/serial_connection.h ('k') | chrome/common/extensions/api/experimental_serial.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698