Add serial bulk reads.

chrome/browser/extensions/api/serial/serial_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <deque>
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 #include "chrome/browser/extensions/api/serial/serial_api.h"
 #include "chrome/browser/extensions/api/serial/serial_connection.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_function.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
@@ skipping 52 matching lines @@
     opened_ = true;
     return true;
   }
 
   virtual void Close() {
     DCHECK(opened_);
   }
 
   virtual void Flush() {
     DCHECK(opened_);
-    read_index_ = write_index_ = 0;
+    buffer_.clear();
   }
 
-  virtual int Read(uint8* byte) {
-    DCHECK(byte);
+  virtual int Read(scoped_refptr<net::IOBufferWithSize> io_buffer) {
+    DCHECK(io_buffer->data());
 
-    if (read_index_ >= write_index_) {
+    if (buffer_.empty()) {
       return 0;
     }
-    *byte = ring_buffer_[read_index_++];
-    if (read_index_ == BUFFER_SIZE)
-      read_index_ = 0;
-    return 1;
+    char *data = io_buffer->data();
+    int bytes_to_copy = io_buffer->size();
+    while (bytes_to_copy-- && !buffer_.empty()) {
+      *data++ = buffer_.front();
+      buffer_.pop_front();
+    }
+    return io_buffer->size();
   }
 
   virtual int Write(scoped_refptr<net::IOBuffer> io_buffer, int byte_count) {
     DCHECK(io_buffer.get());
     DCHECK(byte_count >= 0);
 
     char *data = io_buffer->data();
     int count = byte_count;
-    while (count--) {
-      ring_buffer_[write_index_++] = *data++;
-      if (write_index_ == BUFFER_SIZE)
-        write_index_ = 0;
-    }
+    while (count--)
+      buffer_.push_back(*data++);
     return byte_count;
   }
 
   MOCK_METHOD1(GetControlSignals, bool(ControlSignals &));
   MOCK_METHOD1(SetControlSignals, bool(const ControlSignals &));
 
  private:
-  enum { BUFFER_SIZE = 256 };
   bool opened_;
-  char ring_buffer_[BUFFER_SIZE];
-  int read_index_;
-  int write_index_;
+  std::deque<char> buffer_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeEchoSerialConnection);
 };
 
 class FakeSerialOpenFunction : public SerialOpenFunction {
  protected:
   virtual SerialConnection* CreateSerialConnection(
       const std::string& port,
       int bitrate,
       ApiResourceEventNotifier* event_notifier) OVERRIDE {
@@ skipping 58 matching lines @@
 
   ASSERT_TRUE(RunExtensionTest("serial/api")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(SerialApiTest, SerialRealHardware) {
   ResultCatcher catcher;
   catcher.RestrictToProfile(browser()->profile());
 
   ASSERT_TRUE(RunExtensionTest("serial/real_hardware")) << message_;
 }