Add serial bulk reads.

chrome/browser/extensions/api/serial/serial_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 #include "chrome/browser/extensions/api/serial/serial_api.h"
@@ skipping 59 matching lines @@
 
   virtual void Close() {
     DCHECK(opened_);
   }
 
   virtual void Flush() {
     DCHECK(opened_);
     read_index_ = write_index_ = 0;
   }
 
-  virtual int Read(uint8* byte) {
-    DCHECK(byte);
+  virtual int Read(scoped_refptr<net::IOBufferWithSize> io_buffer) {
+    DCHECK(io_buffer->data());
+    DCHECK(io_buffer->size() <= BUFFER_SIZE);
 
     if (read_index_ >= write_index_) {

[Peng, 2012/08/01 22:14:00]

As it is a ring bufer, I think just testing read_index >= write_index is not
enough.

       return 0;
     }
-    *byte = ring_buffer_[read_index_++];
-    if (read_index_ == BUFFER_SIZE)
-      read_index_ = 0;
-    return 1;
+    char *data = io_buffer->data();
+    int bytes_to_copy = io_buffer->size();
+    while (bytes_to_copy--) {
+      *data++ = ring_buffer_[read_index_++];
+      if (read_index_ == BUFFER_SIZE)
+        read_index_ = 0;
+    }
+    return io_buffer->size();
   }
 
   virtual int Write(scoped_refptr<net::IOBuffer> io_buffer, int byte_count) {
     DCHECK(io_buffer.get());
     DCHECK(byte_count >= 0);
 
     char *data = io_buffer->data();
     int count = byte_count;
     while (count--) {
       ring_buffer_[write_index_++] = *data++;

[Peng, 2012/08/01 22:14:00]

I think here may overwrite unread data.

       if (write_index_ == BUFFER_SIZE)
         write_index_ = 0;
     }
     return byte_count;
   }
 
   MOCK_METHOD1(GetControlSignals, bool(ControlSignals &));
   MOCK_METHOD1(SetControlSignals, bool(const ControlSignals &));
 
  private:
@@ skipping 73 matching lines @@
 
   ASSERT_TRUE(RunExtensionTest("serial/api")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(SerialApiTest, SerialRealHardware) {
   ResultCatcher catcher;
   catcher.RestrictToProfile(browser()->profile());
 
   ASSERT_TRUE(RunExtensionTest("serial/real_hardware")) << message_;
 }