base: Fix minor warnings reported by cppcheck.

base/process_util_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/resource.h>
@@ skipping 235 matching lines @@
   return process;
 }
 
 // Attempts to kill the process identified by the given process
 // entry structure.  Ignores specified exit_code; posix can't force that.
 // Returns true if this is successful, false otherwise.
 bool KillProcess(ProcessHandle process_id, int exit_code, bool wait) {
   DCHECK_GT(process_id, 1) << " tried to kill invalid process_id";
   if (process_id <= 1)
     return false;
-  static unsigned kMaxSleepMs = 1000;
-  unsigned sleep_ms = 4;
-
   bool result = kill(process_id, SIGTERM) == 0;
-
   if (result && wait) {
     int tries = 60;
 
     if (RunningOnValgrind()) {
       // Wait for some extra time when running under Valgrind since the child
       // processes may take some time doing leak checking.
       tries *= 2;
     }
 
+    static const unsigned kMaxSleepMs = 1000;

[jar (doing other things), 2012/08/03 17:20:19]

nit: No need for static.  Also, declare as close as possible to first use (in
this case, only use) before line 288.

+    unsigned sleep_ms = 4;
+
     // The process may not end immediately due to pending I/O
     bool exited = false;
     while (tries-- > 0) {
       pid_t pid = HANDLE_EINTR(waitpid(process_id, NULL, WNOHANG));
       if (pid == process_id) {
         exited = true;
         break;
       }
       if (pid == -1) {
         if (errno == ECHILD) {
@@ skipping 1051 matching lines @@
   if (IsChildDead(process))
     return;
 
   BackgroundReaper* reaper = new BackgroundReaper(process, 0);
   PlatformThread::CreateNonJoinable(0, reaper);
 }
 
 #endif  // !defined(OS_MACOSX)
 
 }  // namespace base