base: Fix minor warnings reported by cppcheck.

base/memory/scoped_ptr_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // Used to test depth subtyping.
 class ConDecLoggerParent {
  public:
   virtual ~ConDecLoggerParent() {}
-  virtual void set_ptr(int* ptr) = 0;
+
+  virtual void SetPtr(int* ptr) = 0;
 
   virtual int SomeMeth(int x) const = 0;
 };
 
 class ConDecLogger : public ConDecLoggerParent {
  public:
   ConDecLogger() : ptr_(NULL) { }
-  explicit ConDecLogger(int* ptr) { set_ptr(ptr); }
+  explicit ConDecLogger(int* ptr) { SetPtr(ptr); }
   virtual ~ConDecLogger() { --*ptr_; }
 
-  virtual void set_ptr(int* ptr) OVERRIDE { ptr_ = ptr; ++*ptr_; }
+  virtual void SetPtr(int* ptr) OVERRIDE { ptr_ = ptr; ++*ptr_; }
 
   virtual int SomeMeth(int x) const OVERRIDE { return x; }
 
  private:
   int* ptr_;
+
   DISALLOW_COPY_AND_ASSIGN(ConDecLogger);
 };
 
 scoped_ptr<ConDecLogger> PassThru(scoped_ptr<ConDecLogger> logger) {
   return logger.Pass();
 }
 
 void GrabAndDrop(scoped_ptr<ConDecLogger> logger) {
 }
 
@@ skipping 146 matching lines @@
 TEST(ScopedPtrTest, ScopedArray) {
   static const int kNumLoggers = 12;
 
   int constructed = 0;
 
   {
     scoped_array<ConDecLogger> scoper(new ConDecLogger[kNumLoggers]);
     EXPECT_TRUE(scoper.get());
     EXPECT_EQ(&scoper[0], scoper.get());
     for (int i = 0; i < kNumLoggers; ++i) {
-      scoper[i].set_ptr(&constructed);
+      scoper[i].SetPtr(&constructed);
     }
     EXPECT_EQ(12, constructed);
 
     EXPECT_EQ(10, scoper.get()->SomeMeth(10));
     EXPECT_EQ(10, scoper[2].SomeMeth(10));
   }
   EXPECT_EQ(0, constructed);
 
   // Test reset() and release()
   {
     scoped_array<ConDecLogger> scoper;
     EXPECT_FALSE(scoper.get());
     EXPECT_FALSE(scoper.release());
     EXPECT_FALSE(scoper.get());
     scoper.reset();
     EXPECT_FALSE(scoper.get());
 
     scoper.reset(new ConDecLogger[kNumLoggers]);
     for (int i = 0; i < kNumLoggers; ++i) {
-      scoper[i].set_ptr(&constructed);
+      scoper[i].SetPtr(&constructed);
     }
     EXPECT_EQ(12, constructed);
     scoper.reset();
     EXPECT_EQ(0, constructed);
 
     scoper.reset(new ConDecLogger[kNumLoggers]);
     for (int i = 0; i < kNumLoggers; ++i) {
-      scoper[i].set_ptr(&constructed);
+      scoper[i].SetPtr(&constructed);
     }
     EXPECT_EQ(12, constructed);
     ConDecLogger* ptr = scoper.release();
     EXPECT_EQ(12, constructed);
     delete[] ptr;
     EXPECT_EQ(0, constructed);
   }
   EXPECT_EQ(0, constructed);
 
   // Test swap(), == and !=
   {
     scoped_array<ConDecLogger> scoper1;
     scoped_array<ConDecLogger> scoper2;
     EXPECT_TRUE(scoper1 == scoper2.get());
     EXPECT_FALSE(scoper1 != scoper2.get());
 
     ConDecLogger* loggers = new ConDecLogger[kNumLoggers];
     for (int i = 0; i < kNumLoggers; ++i) {
-      loggers[i].set_ptr(&constructed);
+      loggers[i].SetPtr(&constructed);
     }
     scoper1.reset(loggers);
     EXPECT_EQ(loggers, scoper1.get());
     EXPECT_FALSE(scoper2.get());
     EXPECT_FALSE(scoper1 == scoper2.get());
     EXPECT_TRUE(scoper1 != scoper2.get());
 
     scoper2.swap(scoper1);
     EXPECT_EQ(loggers, scoper2.get());
     EXPECT_FALSE(scoper1.get());
@@ skipping 92 matching lines @@
     scoped_ptr<ConDecLoggerParent> scoper_parent;
     scoper_parent = UpcastUsingPassAs(scoper.Pass());
     EXPECT_EQ(1, constructed);
     EXPECT_TRUE(scoper_parent.get());
     EXPECT_FALSE(scoper.get());
   }
   EXPECT_EQ(0, constructed);
 }
 
 // TODO scoped_ptr_malloc