Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: chrome/renderer/extensions/extension_resource_request_policy.h

Issue 10827107: Allow transitions to WebUI pages which are extension urls (new tab page is the relevant example). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_resource_request_policy.h
===================================================================
--- chrome/renderer/extensions/extension_resource_request_policy.h (revision 149870)
+++ chrome/renderer/extensions/extension_resource_request_policy.h (working copy)
@@ -5,6 +5,8 @@
#ifndef CHROME_RENDERER_EXTENSIONS_EXTENSION_RESOURCE_REQUEST_POLICY_H_
#define CHROME_RENDERER_EXTENSIONS_EXTENSION_RESOURCE_REQUEST_POLICY_H_
+#include "content/public/common/page_transition_types.h"
+
class ExtensionSet;
class GURL;
namespace WebKit {
@@ -16,9 +18,12 @@
class ExtensionResourceRequestPolicy {
public:
// Returns true if the chrome-extension:// |resource_url| can be requested
- // from |frame_url|.
+ // from |frame_url|. In some cases this decision is made based upon how
+ // this request was generated. Web triggered transitions are more restrictive
+ // than those triggered through UI.
static bool CanRequestResource(const GURL& resource_url,
WebKit::WebFrame* frame,
+ content::PageTransition transition_type,
const ExtensionSet* loaded_extensions);
// Returns true if the chrome-extension-resource:// |resource_url| can be
// requested from |frame_url|.

Powered by Google App Engine
This is Rietveld 408576698