chrome/renderer/extensions/extension_resource_request_policy.h - Issue 10827107: Allow transitions to WebUI pages which are extension urls (new tab page is the relevant example).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_resource_request_policy.h

Issue 10827107: Allow transitions to WebUI pages which are extension urls (new tab page is the relevant example). (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | chrome/renderer/extensions/extension_resource_request_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/extension_resource_request_policy.h

===================================================================

--- chrome/renderer/extensions/extension_resource_request_policy.h (revision 149870)

+++ chrome/renderer/extensions/extension_resource_request_policy.h (working copy)

@@ -5,6 +5,8 @@

#ifndef CHROME_RENDERER_EXTENSIONS_EXTENSION_RESOURCE_REQUEST_POLICY_H_

#define CHROME_RENDERER_EXTENSIONS_EXTENSION_RESOURCE_REQUEST_POLICY_H_

+#include "content/public/common/page_transition_types.h"

class ExtensionSet;

class GURL;

namespace WebKit {

@@ -19,6 +21,7 @@

// from |frame_url|.

Charlie Reis 2012/08/03 21:36:11 Can we say something in this comment about why the

Cris Neckar 2012/08/06 19:25:58 Done.

static bool CanRequestResource(const GURL& resource_url,

WebKit::WebFrame* frame,

+ content::PageTransition transition_type,

const ExtensionSet* loaded_extensions);

// Returns true if the chrome-extension-resource:// |resource_url| can be

// requested from |frame_url|.