[Sync] Preserve old SessionSpecifics data when overwriting tab.

[Sync] Preserve old SessionSpecifics data when overwriting tab.

BUG=139708
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149296

[Nicolas Zea, 2012-07-30 22:03:31]

PTAL. This is a fix which will be necessary for your work, since when you
re-associate all tab nodes at startup the tab_node_id tells you which node is
which (so you can mark it as taken in the tab pool)

[nyquist, 2012-07-31 16:18:36]

On 2012/07/30 22:03:31, nzea wrote:
> PTAL. This is a fix which will be necessary for your work, since when you
> re-associate all tab nodes at startup the tab_node_id tells you which node is
> which (so you can mark it as taken in the tab pool)

LGTM

[commit-bot: I haz the power, 2012-07-31 17:05:36]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Nicolas Zea, 2012-07-31 21:09:45]

+Richard for full star committer review

[rlarocque, 2012-07-31 21:15:56]

LGTM

http://codereview.chromium.org/10827093/diff/1/chrome/browser/sync/glue/sessi...
File chrome/browser/sync/glue/session_model_associator.cc (right):

http://codereview.chromium.org/10827093/diff/1/chrome/browser/sync/glue/sessi...
chrome/browser/sync/glue/session_model_associator.cc:391: sync_pb::SessionTab
tab_s;
That's an unusual variable name, though I guess it's no more unusual than what
it was before.

[commit-bot: I haz the power, 2012-07-31 21:18:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/10827093/1

[commit-bot: I haz the power, 2012-07-31 22:25:55]

Change committed as 149296