gdata: Fix "save as pdf" to work on Google Drive.

chrome/browser/chromeos/gdata/gdata_file_system_interface.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 160 matching lines @@
   virtual void OpenFile(const FilePath& file_path,
                         const OpenFileCallback& callback) = 0;
 
   // Closes a file at the virtual path |file_path| on the gdata file system,
   // which is opened via OpenFile(). It commits the dirty flag on the cache.
   //
   // Can be called from UI/IO thread. |callback| is run on the calling thread.
   virtual void CloseFile(const FilePath& file_path,
                          const FileOperationCallback& callback) = 0;
 
+  // Calls OpenFile, |callback|, then CloseFile in this order.
+  //
+  // Can be called from UI/IO thread. |callback| is run on th blocking thread
+  // pool that allows file operations.
+  virtual void PrepareWritableFileAndRun(const FilePath& path,
+                                         const OpenFileCallback& callback) = 0;

[satorux1, 2012/07/27 22:56:29]

We want to minimize functions in GDataFileSystem. Can you implement this outside
of GDataFileSystem?

Besides, please write a unit test for the new function.

[kinaba, 2012/07/28 00:06:10]

I'll think about it. Do you have any advice where it would be the better place
to put it?
I currently chose to place it inside GDataFileSystem for safely getting (or not
getting, when already destructed) pointer to it for calling CloseFile().

[satorux1, 2012/07/28 00:44:07]

I guess we can move this to gdata_util.cc. For CloseFile(), we should probably
check if GDataSystemService::file_system() is non-null before calling it. I'm
not sure if it's feasible, though.

You might also want to make it a class and put into new files. gdata_util.cc is
also getting bigger. :P

[kinaba, 2012/08/01 13:48:45]

Created a separate class (suggestions are highly welcome for
the name of the class!) and made it to be owned by GDataSystemService.

The reason is, we need to call GDataFileSystem::CloseFile() after
|callback| executed its task on FILE thread, during which, not only
GDataFileSystemInterface but also GDataSystemService and Profile might
have gone (if I understand the lifetime of Profile correctly).
I thought the most handy way to detect this destruction is having a
weak_ptr to an instance (in)directly owned by Profile.

Let me know if there's a better approach.

+
   // Copies |src_file_path| to |dest_file_path| on the file system.
   // |src_file_path| can be a hosted document (see limitations below).
   // |dest_file_path| is expected to be of the same type of |src_file_path|
   // (i.e. if |src_file_path| is a file, |dest_file_path| will be created as
   // a file).
   //
   // This method also has the following assumptions/limitations that may be
   // relaxed or addressed later:
   // - |src_file_path| cannot be a regular file (i.e. non-hosted document)
   //   or a directory.
@@ skipping 154 matching lines @@
                                const FilePath& virtual_dir_path,
                                scoped_ptr<DocumentEntry> entry,
                                const FilePath& file_content_path,
                                GDataCache::FileOperationType cache_operation,
                                const base::Closure& callback) = 0;
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_FILE_SYSTEM_INTERFACE_H_