Added a timezone policy and pyauto tests for it.

chrome/browser/policy/browser_policy_connector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/browser_policy_connector.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/path_service.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/cros_settings.h"
+#include "chrome/browser/chromeos/cros_settings_provider.h"
+#include "chrome/browser/chromeos/system/timezone_settings.h"

[Joao da Silva, 2012/07/27 13:40:57]

Move these to the #if defined(OS_CHROMEOS) below

[pneubeck (no reviews), 2012/07/31 22:21:05]

Done.

 #include "chrome/browser/policy/async_policy_provider.h"
 #include "chrome/browser/policy/cloud_policy_client.h"
 #include "chrome/browser/policy/cloud_policy_provider.h"
 #include "chrome/browser/policy/cloud_policy_service.h"
 #include "chrome/browser/policy/cloud_policy_subsystem.h"
 #include "chrome/browser/policy/configuration_policy_provider.h"
 #include "chrome/browser/policy/device_management_service.h"
 #include "chrome/browser/policy/managed_mode_policy_provider.h"
 #include "chrome/browser/policy/managed_mode_policy_provider_factory.h"
 #include "chrome/browser/policy/policy_service_impl.h"
@@ skipping 537 matching lines @@
 
     device_cloud_policy_subsystem_->CompleteInitialization(
         prefs::kDevicePolicyRefreshRate,
         kServiceInitializationStartupDelay);
   }
   device_data_store_->set_device_status_collector(
       new DeviceStatusCollector(
           g_browser_process->local_state(),
           chromeos::system::StatisticsProvider::GetInstance(),
           NULL));
+
+  SetTimezoneIfPolicyAvailable();

[Joao da Silva, 2012/07/27 13:40:57]

Notice that CompleteInitialization() is only executed if device policy is
enabled. Please do this refactorings:

- move the posting of CompleteInitialization from InitializeDevicePolicy to
Init, and make it unconditional (and execute on every platform). It should be
the last thing done in Init.

- move the posting of GetAppPackUpdater from Init to CompleteInitialization

[pneubeck (no reviews), 2012/07/31 22:21:05]

The only thing, I don't like about the "execute on every platform" is, that
GetAppPackUpdater is also ChromeOS only. Thus if !chromeos we post an empty
task.
Therefore I made it conditional on the chromeos platform.

Is that ok?

 #endif
 }
 
+#if defined(OS_CHROMEOS)

[Joao da Silva, 2012/07/27 13:40:57]

Move the #ifdef into the method, and make the method available on every platform
i.e. remove the #ifdef from the header. See InitializeDevicePolicy for an
example.

[pneubeck (no reviews), 2012/07/31 22:21:05]

Done.

+void BrowserPolicyConnector::SetTimezoneIfPolicyAvailable() {
+  typedef chromeos::CrosSettingsProvider Provider;
+  Provider::TrustedStatus result =
+      chromeos::CrosSettings::Get()->PrepareTrustedValues(
+          base::Bind(&BrowserPolicyConnector::SetTimezoneIfPolicyAvailable,
+                     weak_ptr_factory_.GetWeakPtr()));
+
+  if (result == Provider::TEMPORARILY_UNTRUSTED ||
+     result == Provider::PERMANENTLY_UNTRUSTED)

[Joao da Silva, 2012/07/27 13:40:57]

Nit: indent of the 2nd line
Nit: braces when the conditional or the body span more than 1 line

I'd rather write this as

if (result != Provider::TRUSTED)
  return;

[pneubeck (no reviews), 2012/07/31 22:21:05]

Done.

+    return;
+
+  DCHECK_EQ(result, Provider::TRUSTED);
+
+  std::string timezone;
+  if (chromeos::CrosSettings::Get()->GetString(
+          chromeos::kSystemTimezonePolicy, &timezone)) {
+    chromeos::system::TimezoneSettings::GetInstance()->SetTimezoneFromID(
+        UTF8ToUTF16(timezone));
+  }
+}
+#endif
+
 // static
 ConfigurationPolicyProvider* BrowserPolicyConnector::CreatePlatformProvider() {
 #if defined(OS_WIN)
   const PolicyDefinitionList* policy_list = GetChromePolicyDefinitionList();
   scoped_ptr<AsyncPolicyLoader> loader(new PolicyLoaderWin(policy_list));
   return new AsyncPolicyProvider(loader.Pass());
 #elif defined(OS_MACOSX)
   const PolicyDefinitionList* policy_list = GetChromePolicyDefinitionList();
   scoped_ptr<AsyncPolicyLoader> loader(
       new PolicyLoaderMac(policy_list, new MacPreferences()));
   return new AsyncPolicyProvider(loader.Pass());
 #elif defined(OS_POSIX)
   FilePath config_dir_path;
   if (PathService::Get(chrome::DIR_POLICY_FILES, &config_dir_path)) {
     scoped_ptr<AsyncPolicyLoader> loader(
         new ConfigDirPolicyLoader(config_dir_path, POLICY_SCOPE_MACHINE));
     return new AsyncPolicyProvider(loader.Pass());
   } else {
     return NULL;
   }
 #else
   return NULL;
 #endif
 }
 
 }  // namespace policy