src/objects-debug.cc - Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 10827037: Extending map verification to also verify LastAdded/DescriptorArray consistency. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 3047326e2ab195789d438c7e7efc15802cdebbe7..c738d905bc414330cff89f8c33873ffe2cc929c3 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -302,6 +302,12 @@ void Map::MapVerify() {

instance_size() < HEAP->Capacity()));

VerifyHeapPointer(prototype());

VerifyHeapPointer(instance_descriptors());

+ if (instance_descriptors()->number_of_descriptors() == 0) {

+ ASSERT(LastAdded() == kNoneAdded);

+ } else {

+ ASSERT(instance_descriptors()->GetDetails(LastAdded()).index() ==

+ NumberOfSetDescriptors());

danno 2012/07/26 14:42:09 How about NumberOfOwnDescriptors, or just use numb

+ }

SLOW_ASSERT(instance_descriptors()->IsSortedNoDuplicates());

if (HasTransitionArray()) {

SLOW_ASSERT(transitions()->IsSortedNoDuplicates());

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »