Fix coordinates in tab detach &drag code and multi window resizer.

Fix coordinates in tab detach/drag and multi window resizer.

ToplevelWindowEventFilter:
* Use location in root window for drag_location

DocInfo::GetLocalProcessWindowAtPoint
* Use ScreenPositionClient to convert a point in screen to window
* Use correct root window at the position.

MultiWindowResizer
* Use ScreenPositionClient to convert a point in screen to window.
* show_bounds_ should be screen coordinates.

I also renamed {screen|parent}_{location|position| to
{location|position}_in_{screen|parent} to be more explicit and consistent with the rest of the code.

I'll work on the test separately as we discussed offline.

BUG=138997, 138868
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148478

[sky, 2012-07-25 23:51:41]

LGTM

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_event_filter.cc (right):

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_event_filter.cc:120: const gfx::Point&
point_in_parent,
rename argument in header to match.

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_window_resizer.cc:55: const gfx::Point&
location_in_parent,
rename argument in header to match.

[oshima, 2012-07-25 23:55:14]

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_event_filter.cc (right):

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_event_filter.cc:120: const gfx::Point&
point_in_parent,
On 2012/07/25 23:51:41, sky wrote:
> rename argument in header to match.

Done.

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
File ash/wm/workspace/workspace_window_resizer.cc (right):

http://codereview.chromium.org/10827022/diff/4002/ash/wm/workspace/workspace_...
ash/wm/workspace/workspace_window_resizer.cc:55: const gfx::Point&
location_in_parent,
On 2012/07/25 23:51:41, sky wrote:
> rename argument in header to match.

Done.

[commit-bot: I haz the power, 2012-07-26 00:06:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10827022/12001

[commit-bot: I haz the power, 2012-07-26 00:06:17]

Failed to apply patch for chrome/browser/ui/views/tabs/tab_drag_controller.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/views/tabs/tab_drag_controller.cc
Hunk #30 FAILED at 1881.
1 out of 30 hunks FAILED -- saving rejects to file
chrome/browser/ui/views/tabs/tab_drag_controller.cc.rej

[commit-bot: I haz the power, 2012-07-26 00:16:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10827022/10003

[commit-bot: I haz the power, 2012-07-26 02:17:26]

Change committed as 148478