Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10827011: Switched button order for manage dialog (Closed)

Created:
8 years, 5 months ago by Halli
Modified:
8 years, 5 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Switched button order for create dialog to match the order from manage dialog. Cancel/OK should be consistent between Create, Manage, and Delete dialogs. BUG=138590 TEST= Manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148445

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options2/manage_profile_overlay.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Halli
8 years, 5 months ago (2012-07-25 17:47:58 UTC) #1
Halli
8 years, 5 months ago (2012-07-25 18:06:13 UTC) #2
James Hawkins
http://codereview.chromium.org/10827011/diff/3001/chrome/browser/resources/options2/manage_profile_overlay.html File chrome/browser/resources/options2/manage_profile_overlay.html (left): http://codereview.chromium.org/10827011/diff/3001/chrome/browser/resources/options2/manage_profile_overlay.html#oldcode44 chrome/browser/resources/options2/manage_profile_overlay.html:44: <button id="delete-profile-cancel" i18n-content="cancel"></button> This one is correct as-is.
8 years, 5 months ago (2012-07-25 18:14:35 UTC) #3
Halli
Sorry, didn't realize I changed that one! http://codereview.chromium.org/10827011/diff/3001/chrome/browser/resources/options2/manage_profile_overlay.html File chrome/browser/resources/options2/manage_profile_overlay.html (left): http://codereview.chromium.org/10827011/diff/3001/chrome/browser/resources/options2/manage_profile_overlay.html#oldcode44 chrome/browser/resources/options2/manage_profile_overlay.html:44: <button id="delete-profile-cancel" ...
8 years, 5 months ago (2012-07-25 18:21:32 UTC) #4
James Hawkins
lgtm
8 years, 5 months ago (2012-07-25 18:23:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hallielaine@chromium.org/10827011/3002
8 years, 5 months ago (2012-07-25 18:25:42 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 5 months ago (2012-07-25 20:07:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hallielaine@chromium.org/10827011/3002
8 years, 5 months ago (2012-07-25 20:09:47 UTC) #8
commit-bot: I haz the power
Try job failure for 10827011-3002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-25 21:29:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hallielaine@chromium.org/10827011/3002
8 years, 5 months ago (2012-07-25 21:41:02 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 23:00:20 UTC) #11
Change committed as 148445

Powered by Google App Engine
This is Rietveld 408576698