Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 10827009: Don't show tray on OOBE boot (Closed)

Created:
8 years, 5 months ago by Nikita (slow)
Modified:
8 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Don't show tray on OOBE boot. New OOBE boot up sequence revealed an issue when tray was shown on boot, then hidden again. 1. OOBE WebUI is not initialized as it waits for wallpaper animation to finish. That means tray was not hidden by WebUI. 3. Wallpaper animations happens 4. At some point tray is shown 5. WebUI is initialized, tray is hidden. BUG=133279 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148387

Patch Set 1 #

Patch Set 2 : proper fix #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 1 chunk +5 lines, -2 lines 3 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
Sadrul, please take a look.
8 years, 5 months ago (2012-07-25 17:33:58 UTC) #1
sadrul
LGTM http://codereview.chromium.org/10827009/diff/2001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/10827009/diff/2001/chrome/browser/chromeos/login/webui_login_view.cc#newcode240 chrome/browser/chromeos/login/webui_login_view.cc:240: // Tray may have been initialized being hidden. ...
8 years, 5 months ago (2012-07-25 17:47:28 UTC) #2
Nikita (slow)
http://codereview.chromium.org/10827009/diff/2001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/10827009/diff/2001/chrome/browser/chromeos/login/webui_login_view.cc#newcode240 chrome/browser/chromeos/login/webui_login_view.cc:240: // Tray may have been initialized being hidden. On ...
8 years, 5 months ago (2012-07-25 17:54:17 UTC) #3
sadrul
http://codereview.chromium.org/10827009/diff/2001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): http://codereview.chromium.org/10827009/diff/2001/chrome/browser/chromeos/login/webui_login_view.cc#newcode240 chrome/browser/chromeos/login/webui_login_view.cc:240: // Tray may have been initialized being hidden. On ...
8 years, 5 months ago (2012-07-25 17:56:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10827009/2001
8 years, 5 months ago (2012-07-25 18:27:42 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 19:58:26 UTC) #6
Change committed as 148387

Powered by Google App Engine
This is Rietveld 408576698