Issue 10827003: Attempt at a crash fix in LazyBackgroundTaskQueue::ProcessPendingTasks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827003: Attempt at a crash fix in LazyBackgroundTaskQueue::ProcessPendingTasks. (Closed)

Created:
8 years, 5 months ago by Matt Perry

Modified:
8 years, 5 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Attempt at a crash fix in LazyBackgroundTaskQueue::ProcessPendingTasks. According to windbg, it was crashing on this line: it->Run(host); My hypothesis is that one of the tasks modified the task list, corrupting the iterator. BUG=138790 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148402

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	chrome/browser/extensions/lazy_background_task_queue.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10827003/1

8 years, 5 months ago (2012-07-25 18:49:19 UTC) #3

Change committed as 148402

Expand Messages | Collapse Messages