Allocate a one-byte IOBuffer for transfers that are zero-length.

Allocate a one-byte IOBuffer for transfers that are zero-length.

Since IOBuffers cannot be zero-length, but are used to back zero-length URBs,
allocate a single unused byte to back zero-length transfers.

BUG=128636
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151323

[bryeung, 2012-08-13 15:22:28]

lgtm

https://chromiumcodereview.appspot.com/10826273/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/usb/usb_device_resource.cc (right):

https://chromiumcodereview.appspot.com/10826273/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/usb/usb_device_resource.cc:120: if
(!input.data.get()) {
nit: this if and the one above should be brace-less

[asargent_no_longer_on_chrome, 2012-08-13 17:37:50]

lgtm

http://codereview.chromium.org/10826273/diff/4001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/usb/usb_device_resource.cc (right):

http://codereview.chromium.org/10826273/diff/4001/chrome/browser/extensions/a...
chrome/browser/extensions/api/usb/usb_device_resource.cc:117:
scoped_refptr<net::IOBuffer> buffer = new net::IOBuffer(std::max(
can you include a brief comment here about why we need the buffer to be at least
1 byte?

[commit-bot: I haz the power, 2012-08-13 17:48:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gdk@chromium.org/10826273/3002

[commit-bot: I haz the power, 2012-08-13 19:03:01]

Change committed as 151323