Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 10826251: Cherry-pick 159409 for TLS Initial Exec fix. (Closed)

Created:
8 years, 4 months ago by jvoung (off chromium)
Modified:
8 years, 4 months ago
Reviewers:
sehr, Derek Schuff
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Cherry-pick llvm rev 159409 for TLS Initial Exec fix. Turns out that it is also fixed upstream, so no localmods! http://llvm.org/viewvc/llvm-project?view=rev&revision=159409 BUG= http://code.google.com/p/nativeclient/issues/detail?id=2960

Patch Set 1 #

Patch Set 2 : cherry pick instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M llvm/lib/Target/X86/X86ISelLowering.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M llvm/test/CodeGen/X86/tls-pie.ll View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
8 years, 4 months ago (2012-08-10 19:47:32 UTC) #1
Derek Schuff
On 2012/08/10 19:47:32, jvoung (chromium) wrote: LGTM. I wonder if maybe it's time for another ...
8 years, 4 months ago (2012-08-10 19:50:03 UTC) #2
jvoung - send to chromium...
8 years, 4 months ago (2012-08-10 19:50:59 UTC) #3
On 2012/08/10 19:50:03, dschuff wrote:
> On 2012/08/10 19:47:32, jvoung (chromium) wrote:
> 
> LGTM.
> I wonder if maybe it's time for another merge

Maybe -- it's been more than a month, but I guess we may want to move to git
first...

Powered by Google App Engine
This is Rietveld 408576698