Add local file system directory listings support for GTK content shell.

Add local file system directory listings support for GTK content shell.

BUG=90445
TEST=

[Shouqun Liu, 2012-08-10 08:21:17]

Hi, this patch adds support for local file system directory listing for GTK
content shell. Implement the Shell::PlatformResourceProvider to let content
shell get the directory listing html resources.   Thanks for review!

[jochen (gone - plz use gerrit), 2012-08-10 09:48:05]

instead of adding the net resources directly, you should include them in the
content_shell_resources.pak (using the repack rules). Then you can just load
them out of the resource bundle

https://chromiumcodereview.appspot.com/10826242/diff/1/content/content_shell....
File content/content_shell.gypi (right):

https://chromiumcodereview.appspot.com/10826242/diff/1/content/content_shell....
content/content_shell.gypi:29: '<(DEPTH)/net/net.gyp:net_resources',
this should go next to the other _resources dependencies, such as
webkit_resources

[jam, 2012-08-10 15:06:15]

http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc#new...
content/shell/shell_gtk.cc:33: IDR_DIR_HEADER_HTML, ui::SCALE_FACTOR_NONE);
this code looks like it's cross platform (i.e. we call ResourceBundle in 4 other
places that are platform-independent). I'm not sure why there's a separate
Shell::PlatformResourceProvider function per platform, it seems there should
just be one only and this code is all shared.

[jam, 2012-08-10 15:10:10]

http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc#new...
content/shell/shell_gtk.cc:33: IDR_DIR_HEADER_HTML, ui::SCALE_FACTOR_NONE);
nvm, juts saw that Windows is the only one that has a non-empty function:
GetRawDataResource(::GetModuleHandle(NULL), key)

I wonder if we had this code instead if it would work on Windows?

[jam, 2012-08-10 15:42:04]

http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc
File content/shell/shell_gtk.cc (right):

http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc#new...
content/shell/shell_gtk.cc:33: IDR_DIR_HEADER_HTML, ui::SCALE_FACTOR_NONE);
On 2012/08/10 15:10:10, John Abd-El-Malek wrote:
> nvm, juts saw that Windows is the only one that has a non-empty function:
> GetRawDataResource(::GetModuleHandle(NULL), key)
> 
> I wonder if we had this code instead if it would work on Windows?

just tried this on Windows, and it worked. here's a patch based on this:
http://codereview.chromium.org/10830260/

[Shouqun Liu, 2012-08-11 02:26:44]

Hi John, thanks for verifying this on Windows,  I do not have a Windows built
environment currently (maybe I need to setup one).  
Your patch is much better for cross-platform.  thanks:)

On 2012/08/10 15:42:04, John Abd-El-Malek wrote:
> http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc
> File content/shell/shell_gtk.cc (right):
> 
>
http://codereview.chromium.org/10826242/diff/1/content/shell/shell_gtk.cc#new...
> content/shell/shell_gtk.cc:33: IDR_DIR_HEADER_HTML, ui::SCALE_FACTOR_NONE);
> On 2012/08/10 15:10:10, John Abd-El-Malek wrote:
> > nvm, juts saw that Windows is the only one that has a non-empty function:
> > GetRawDataResource(::GetModuleHandle(NULL), key)
> > 
> > I wonder if we had this code instead if it would work on Windows?
> 
> just tried this on Windows, and it worked. here's a patch based on this:
> http://codereview.chromium.org/10830260/

[jam, 2012-08-13 00:48:14]

On 2012/08/11 02:26:44, Shouqun Liu wrote:
> Hi John, thanks for verifying this on Windows,  I do not have a Windows built
> environment currently (maybe I need to setup one).  
> Your patch is much better for cross-platform.  thanks:)

thanks for your patch, I always wanted this to work in content_shell but never
had time to investigate :)

[Shouqun Liu, 2012-08-14 18:38:48]

Hi jam, I'm glad to contribute to chromium/content_shell, seems content_shell
still has some missing features to be a basic browser shell.  Do you have a TODO
list on it? Maybe I can help work on these:)
 
On 2012/08/13 00:48:14, John Abd-El-Malek wrote:
> On 2012/08/11 02:26:44, Shouqun Liu wrote:
> > Hi John, thanks for verifying this on Windows,  I do not have a Windows
built
> > environment currently (maybe I need to setup one).  
> > Your patch is much better for cross-platform.  thanks:)
> 
> thanks for your patch, I always wanted this to work in content_shell but never
> had time to investigate :)

[jochen (gone - plz use gerrit), 2012-08-14 18:49:23]

If I'm not mistaken, opening a context menu crashes content_shell on all
platforms? it probably should at least not crash

On Tue, Aug 14, 2012 at 8:38 PM, <shouqun.liu@intel.com> wrote:

> Hi jam, I'm glad to contribute to chromium/content_shell, seems
> content_shell
> still has some missing features to be a basic browser shell.  Do you have
> a TODO
> list on it? Maybe I can help work on these:)
>
>
> On 2012/08/13 00:48:14, John Abd-El-Malek wrote:
>
>> On 2012/08/11 02:26:44, Shouqun Liu wrote:
>> > Hi John, thanks for verifying this on Windows,  I do not have a Windows
>>
> built
>
>> > environment currently (maybe I need to setup one).
>> > Your patch is much better for cross-platform.  thanks:)
>>
>
>  thanks for your patch, I always wanted this to work in content_shell but
>> never
>> had time to investigate :)
>>
>
>
>
>
http://codereview.chromium.**org/10826242/<http://codereview.chromium.org/108...
>

[Shouqun Liu, 2012-08-14 19:27:30]

OK, I'll looking at this:)
On 2012/08/14 18:49:23, jochen wrote:
> If I'm not mistaken, opening a context menu crashes content_shell on all
> platforms? it probably should at least not crash
> 
> On Tue, Aug 14, 2012 at 8:38 PM, <mailto:shouqun.liu@intel.com> wrote:
> 
> > Hi jam, I'm glad to contribute to chromium/content_shell, seems
> > content_shell
> > still has some missing features to be a basic browser shell.  Do you have
> > a TODO
> > list on it? Maybe I can help work on these:)
> >
> >
> > On 2012/08/13 00:48:14, John Abd-El-Malek wrote:
> >
> >> On 2012/08/11 02:26:44, Shouqun Liu wrote:
> >> > Hi John, thanks for verifying this on Windows,  I do not have a Windows
> >>
> > built
> >
> >> > environment currently (maybe I need to setup one).
> >> > Your patch is much better for cross-platform.  thanks:)
> >>
> >
> >  thanks for your patch, I always wanted this to work in content_shell but
> >> never
> >> had time to investigate :)
> >>
> >
> >
> >
> >
>
http://codereview.chromium.**org/10826242/%3Chttp://codereview.chromium.org/1...>
> >