Chromium Code Reviews| Index: base/message_pump_win.cc |
| diff --git a/base/message_pump_win.cc b/base/message_pump_win.cc |
| index 40118dab657c5d6675311ddf74b090a3ee4d19b7..59e9d1c6ac93008a05683a146e313d717b0bebae 100644 |
| --- a/base/message_pump_win.cc |
| +++ b/base/message_pump_win.cc |
| @@ -95,7 +95,9 @@ int MessagePumpWin::GetCurrentDelay() const { |
| //----------------------------------------------------------------------------- |
| // MessagePumpForUI public: |
| -MessagePumpForUI::MessagePumpForUI() : instance_(NULL) { |
| +MessagePumpForUI::MessagePumpForUI() |
| + : instance_(NULL), |
| + message_filter_(new MessageFilter) { |
| InitMessageWnd(); |
| } |
| @@ -295,16 +297,17 @@ void MessagePumpForUI::WaitForWork() { |
| // If a parent child relationship exists between windows across threads |
| // then their thread inputs are implicitly attached. |
| // This causes the MsgWaitForMultipleObjectsEx API to return indicating |
| - // that messages are ready for processing (specifically mouse messages |
| - // intended for the child window. Occurs if the child window has capture) |
| - // The subsequent PeekMessages call fails to return any messages thus |
| + // that messages are ready for processing (Specifically, mouse messages |
| + // intended for the child window may appear if the child window has |
| + // capture). |
| + // The subsequent PeekMessages call may fail to return any messages thus |
| // causing us to enter a tight loop at times. |
| // The WaitMessage call below is a workaround to give the child window |
| - // sometime to process its input messages. |
| + // some time to process its input messages. |
| MSG msg = {0}; |
| DWORD queue_status = GetQueueStatus(QS_MOUSE); |
| if (HIWORD(queue_status) & QS_MOUSE && |
| - !PeekMessage(&msg, NULL, WM_MOUSEFIRST, WM_MOUSELAST, PM_NOREMOVE)) { |
| + !PeekMessage(&msg, NULL, WM_MOUSEFIRST, WM_MOUSELAST, PM_NOREMOVE)) { |
| WaitMessage(); |
| } |
| return; |
| @@ -361,7 +364,7 @@ bool MessagePumpForUI::ProcessNextWindowsMessage() { |
| sent_messages_in_queue = true; |
| MSG msg; |
| - if (PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) |
| + if (message_filter_->DoPeekMessage(&msg, NULL, 0, 0, PM_REMOVE)) |
| return ProcessMessageHelper(msg); |
| return sent_messages_in_queue; |
| @@ -387,12 +390,14 @@ bool MessagePumpForUI::ProcessMessageHelper(const MSG& msg) { |
| WillProcessMessage(msg); |
| - if (state_->dispatcher) { |
| - if (!state_->dispatcher->Dispatch(msg)) |
| - state_->should_quit = true; |
| - } else { |
| - TranslateMessage(&msg); |
| - DispatchMessage(&msg); |
| + if (!message_filter_->ProcessMessage(msg)) { |
| + if (state_->dispatcher) { |
| + if (!state_->dispatcher->Dispatch(msg)) |
| + state_->should_quit = true; |
| + } else { |
| + TranslateMessage(&msg); |
| + DispatchMessage(&msg); |
| + } |
| } |
| DidProcessMessage(msg); |
| @@ -419,7 +424,8 @@ bool MessagePumpForUI::ProcessPumpReplacementMessage() { |
| have_message = PeekMessage(&msg, NULL, WM_PAINT, WM_PAINT, PM_REMOVE) || |
| PeekMessage(&msg, NULL, WM_TIMER, WM_TIMER, PM_REMOVE); |
| } else { |
| - have_message = (0 != PeekMessage(&msg, NULL, 0, 0, PM_REMOVE)); |
| + have_message = !!message_filter_->DoPeekMessage(&msg, NULL, 0, 0, |
| + PM_REMOVE); |
| } |
| DCHECK(!have_message || kMsgHaveWork != msg.message || |
| @@ -441,6 +447,11 @@ bool MessagePumpForUI::ProcessPumpReplacementMessage() { |
| return ProcessMessageHelper(msg); |
| } |
| +void MessagePumpForUI::SetMessageFilter( |
| + scoped_ptr<MessageFilter> message_filter) { |
|
darin (slow to review)
2012/09/07 07:33:51
nit: indent by 4 spaces for line continuations
yoichio
2012/09/07 07:51:36
Done.
|
| + message_filter_ = message_filter.Pass(); |
| +} |
| + |
| //----------------------------------------------------------------------------- |
| // MessagePumpForIO public: |