[net/dns] Hardcode DnsConfig.timeout to 1 second.

net/dns/dns_config_service_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_config_service_posix.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 40 matching lines @@
   } else {
     result = CONFIG_PARSE_POSIX_RES_INIT_FAILED;
   }
   // Prefer res_ndestroy where available.
 #if defined(OS_MACOSX) || defined(OS_FREEBSD)
   res_ndestroy(&res);
 #else
   res_nclose(&res);
 #endif
 #endif
+  // Override timeout value to match default setting on Windows.
+  config->timeout = base::TimeDelta::FromSeconds(1);

[cbentzel, 2012/08/09 20:29:08]

min of timeout and 1 second?

Could 1s move to a constant in a header?

[szym, 2012/08/09 20:59:29]

Done. Another option is to completely remove the code which sets
DnsConfig::timeout along with the tests and only set it in DnsConfig::DnsConfig.
I plan to do this eventually, but should I just do it now?

   return result;
 }
 
 // A SerialWorker that uses libresolv to initialize res_state and converts
 // it to DnsConfig.
 class ConfigReader : public SerialWorker {
  public:
   typedef base::Callback<void(const DnsConfig& config)> CallbackType;
   explicit ConfigReader(const CallbackType& callback)
       : callback_(callback), success_(false) {}
@@ skipping 212 matching lines @@
   virtual ~StubDnsConfigService() {}
   virtual void OnDNSChanged(unsigned detail) OVERRIDE {}
 };
 // static
 scoped_ptr<DnsConfigService> DnsConfigService::CreateSystemService() {
   return scoped_ptr<DnsConfigService>(new StubDnsConfigService());
 }
 #endif
 
 }  // namespace net