Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 10826209: gestures: Generate only either scroll-end or fling-start events at the end of a scroll gesture. (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
rjkroege, xiyuan, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

gestures: Generate only either scroll-end or fling-start events at the end of a scroll gesture. When a fling happens at the end of a scroll, instead of generating both a scroll-end and a fling-start event, generate only fling-start event. Unfortunately, WebKit still requires an explicit scroll-end gesture before a fling, so continue to do that as a special case. BUG=141460, 141309 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150852

Patch Set 1 #

Patch Set 2 : applist-fling #

Patch Set 3 : win-fix #

Total comments: 3

Patch Set 4 : remove-webkit-hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -41 lines) Patch
M ash/wm/toplevel_window_event_filter.cc View 1 2 3 1 chunk +14 lines, -9 lines 0 comments Download
M ui/app_list/contents_view.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/app_list/pagination_model.h View 1 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/pagination_model.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 4 chunks +13 lines, -8 lines 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M ui/views/events/event.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/root_view.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
8 years, 4 months ago (2012-08-08 20:07:18 UTC) #1
xiyuan
Awesome. It works great. Both touch scroll and fling works as expected in app list. ...
8 years, 4 months ago (2012-08-08 20:38:49 UTC) #2
sadrul
rjkroege@ Please review content/ and gestures/ sky@ Please review ash/ content/ and views/ xiyuan@ Please ...
8 years, 4 months ago (2012-08-09 00:21:58 UTC) #3
sky
LGTM
8 years, 4 months ago (2012-08-09 00:43:16 UTC) #4
xiyuan
app_list/ LGTM
8 years, 4 months ago (2012-08-09 16:21:27 UTC) #5
rjkroege
gr changes LGTM. http://codereview.chromium.org/10826209/diff/20/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): http://codereview.chromium.org/10826209/diff/20/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode1322 content/browser/renderer_host/render_widget_host_view_aura.cc:1322: // WebKit requires that a scroll ...
8 years, 4 months ago (2012-08-09 16:51:06 UTC) #6
sadrul
8 years, 4 months ago (2012-08-09 17:44:02 UTC) #7
http://codereview.chromium.org/10826209/diff/20/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

http://codereview.chromium.org/10826209/diff/20/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_aura.cc:1322: // WebKit
requires that a scroll ends first before a fling starts.
On 2012/08/09 16:51:06, rjkroege wrote:
> It is planned to remove this requirement on WebKit. Did you test without the
> presence of this code? It is my intent that this ought to be removed from here
> if it is currently necessary.

Nice! My impression was that it was still necessary. But I tried without this
block of code, in debug and release builds on desktop, and on device, and scroll
with/without fling seems to work fine. So I have removed this change. Thanks!

Powered by Google App Engine
This is Rietveld 408576698