Remove SyncManager::Init() return value

chrome/browser/sync/glue/sync_backend_host.cc

Index: chrome/browser/sync/glue/sync_backend_host.cc
diff --git a/chrome/browser/sync/glue/sync_backend_host.cc b/chrome/browser/sync/glue/sync_backend_host.cc
index 9b7d19d2c7a57677bb69b5fbf07f0e43af463a78..5f368cf3eeddc0ae170d4d802cf2527e79799432 100644
--- a/chrome/browser/sync/glue/sync_backend_host.cc
+++ b/chrome/browser/sync/glue/sync_backend_host.cc
@@ -1046,8 +1046,7 @@ void SyncBackendHost::Core::DoInitialize(const DoInitializeOptions& options) {
 
   // Make sure that the directory exists before initializing the backend.
   // If it already exists, this will do no harm.
-  bool success = file_util::CreateDirectory(sync_data_folder_path_);
-  DCHECK(success);
+  DCHECK(file_util::CreateDirectory(sync_data_folder_path_));

[akalin, 2012/08/08 23:01:46]

this is dangerous!  DCHECKs get compiled out in release builds.

[rlarocque, 2012/08/09 00:01:38]

That's a very good point.  I should not put code with side-effects inside a
DCHECK.

 
   DCHECK(!registrar_);
   registrar_ = options.registrar;
@@ -1059,7 +1058,7 @@ void SyncBackendHost::Core::DoInitialize(const DoInitializeOptions& options) {
 
   sync_manager_ = options.sync_manager_factory->CreateSyncManager(name_);
   sync_manager_->AddObserver(this);
-  success = sync_manager_->Init(
+  sync_manager_->Init(
       sync_data_folder_path_,
       options.event_handler,
       options.service_url.host() + options.service_url.path(),
@@ -1083,7 +1082,6 @@ void SyncBackendHost::Core::DoInitialize(const DoInitializeOptions& options) {
       &encryptor_,
       options.unrecoverable_error_handler,
       options.report_unrecoverable_error_function);
-  LOG_IF(ERROR, !success) << "Sync manager initialization failed!";
 
   // Now check the command line to see if we need to simulate an
   // unrecoverable error for testing purpose. Note the error is thrown