Allow disabling input throttle through RendererPreference (for Browser Plugin guests)

Allow disabling input throttle through RendererPreference (for Browser Plugin guests) 

BUG=140306
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150802

[Fady Samuel, 2012-08-07 17:55:53]

Hi Darin,

This is what we discussed briefly a couple of weeks ago. Disabling input
throttle as a renderer preference.

Thanks,

Fady

[Fady Samuel, 2012-08-07 17:55:54]

Hi Darin,

This is what we discussed briefly a couple of weeks ago. Disabling input
throttle as a renderer preference.

Thanks,

Fady

[Fady Samuel, 2012-08-07 19:30:06]

Not sure if Darin is around today. Adding jam@ as an alternative.

The browser plugin's guests should not be throttled because throttling already
happens in the embedder process (and throttling makes it hard to avoid
deadlocks). Darin suggested we make this a RendererPreference last we met.

[darin (slow to review), 2012-08-07 21:54:39]

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget.cc
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget...
content/renderer/render_widget.cc:148: new RenderWidget(popup_type, screen_info,
false, false));
nit: it is unfortunate to have methods with lists of bool params as the
callsites become fairly unreadable.  how about just creating a setter to disable
input throttling?  set_throttle_input_events(false)

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget.h
File content/renderer/render_widget.h (right):

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget...
content/renderer/render_widget.h:576: bool disable_input_throttle_;
nit: it is probably better to negate this variable so it can be named
"throttle_input_events_".  the place where the variable gets used would then not
need to be negated.

[Fady Samuel, 2012-08-07 22:17:22]

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget.cc
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget...
content/renderer/render_widget.cc:148: new RenderWidget(popup_type, screen_info,
false, false));
On 2012/08/07 21:54:39, darin wrote:
> nit: it is unfortunate to have methods with lists of bool params as the
> callsites become fairly unreadable.  how about just creating a setter to
disable
> input throttling?  set_throttle_input_events(false)

Done.

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget.h
File content/renderer/render_widget.h (right):

http://codereview.chromium.org/10826189/diff/1/content/renderer/render_widget...
content/renderer/render_widget.h:576: bool disable_input_throttle_;
On 2012/08/07 21:54:39, darin wrote:
> nit: it is probably better to negate this variable so it can be named
> "throttle_input_events_".  the place where the variable gets used would then
not
> need to be negated.

Done.

[Fady Samuel, 2012-08-08 17:00:49]

friendly ping :-)

[darin (slow to review), 2012-08-09 08:06:27]

LGTM

[commit-bot: I haz the power, 2012-08-09 14:04:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10826189/10

[commit-bot: I haz the power, 2012-08-09 15:53:59]

Change committed as 150802